You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/18 07:52:46 UTC
[GitHub] [shardingsphere] dmsolr opened a new pull request #9725: refactor: it engine
dmsolr opened a new pull request #9725:
URL: https://github.com/apache/shardingsphere/pull/9725
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
Reference #9461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #9725: refactor: it engine
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #9725:
URL: https://github.com/apache/shardingsphere/pull/9725#discussion_r600152279
##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-fixture/Dockerfile
##########
@@ -18,10 +18,22 @@
FROM openjdk:8-jdk-alpine
ARG APP_NAME
-ENV WAIT_VERSION 2.7.2
ADD target/${APP_NAME}.tar.gz /opt
-ADD https://github.com/ufoscout/docker-compose-wait/releases/download/$WAIT_VERSION/wait /wait
-RUN chmod +x /wait
RUN mv /opt/${APP_NAME} /opt/shardingsphere-proxy
-ENTRYPOINT /wait && /opt/shardingsphere-proxy/bin/start.sh && tail -f /opt/shardingsphere-proxy/logs/stdout.log
+
+# ADD ./target/shardingsphere-agent.tar.gz /opt/shardingsphere-proxy/shardingsphere-agent
+
+EXPOSE 3307
+EXPOSE 3308
+
+#HEALTHCHECK --interval=1ms --timeout=60s --retries=1 \
+# CMD (tail -f -n200 /opt/shardingsphere-proxy/logs/stdout.log |grep -q "ShardingSphere-Proxy start success")
Review comment:
It is better to remove temp codes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #9725: refactor: it engine
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #9725:
URL: https://github.com/apache/shardingsphere/pull/9725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org