You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "VersusFacit (via GitHub)" <gi...@apache.org> on 2025/07/07 18:06:41 UTC

[PR] Make now considers other dirs for changes. [arrow-adbc]

VersusFacit opened a new pull request, #3108:
URL: https://github.com/apache/arrow-adbc/pull/3108

   QoL upgrade for driver development. More complete tracking for local changes. Saves on `rm`-ing before rebuilding libraries to integrate source changes!
   
   Also I replaced an error-prone `$<` (subtarget position dependent) with `$*` 
   
   ## Demo
   
   ![demo](https://github.com/user-attachments/assets/8f9ff140-5bac-402a-934e-077e01e2d475)
   
   ## Scenarios covered
   1. edit already tracked driver files
   2. edit `go.mod`
   3. edit `../driver/bigquery` files
   4. (not shown but works) edit other package like `../driver/databricks` and `../go.sum` --> triggers no rebuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: go driver makefile now considers more source files as dependencies [arrow-adbc]

Posted by "VersusFacit (via GitHub)" <gi...@apache.org>.
VersusFacit commented on code in PR #3108:
URL: https://github.com/apache/arrow-adbc/pull/3108#discussion_r2190915642


##########
go/adbc/pkg/Makefile:
##########
@@ -14,8 +14,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-GO_BUILD=go build
-RM=rm -f
+MANAGERS = bigquery flightsql panicdummy snowflake

Review Comment:
   warehouses felt wrong and databases too so this is what's left 😆 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: go driver makefile now considers more source files as dependencies [arrow-adbc]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #3108:
URL: https://github.com/apache/arrow-adbc/pull/3108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: go driver makefile now considers more source files as dependencies [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #3108:
URL: https://github.com/apache/arrow-adbc/pull/3108#discussion_r2191190873


##########
go/adbc/pkg/Makefile:
##########
@@ -14,8 +14,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-GO_BUILD=go build
-RM=rm -f
+MANAGERS = bigquery flightsql panicdummy snowflake

Review Comment:
   I think we often say "vendors"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: go driver makefile now considers more source files as dependencies [arrow-adbc]

Posted by "VersusFacit (via GitHub)" <gi...@apache.org>.
VersusFacit commented on code in PR #3108:
URL: https://github.com/apache/arrow-adbc/pull/3108#discussion_r2194302923


##########
go/adbc/pkg/Makefile:
##########
@@ -14,8 +14,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-GO_BUILD=go build
-RM=rm -f
+MANAGERS = bigquery flightsql panicdummy snowflake

Review Comment:
   Ah good suggestion! I'll carry that forward especially for future upstream proposals 🙏 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: go driver makefile now considers more source files as dependencies [arrow-adbc]

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #3108:
URL: https://github.com/apache/arrow-adbc/pull/3108#discussion_r2190774782


##########
go/adbc/pkg/Makefile:
##########
@@ -28,17 +31,18 @@ endif
 GIT_VERSION=$(shell git tag -l --points-at $(shell git rev-list --tags --max-count=1) --sort=-v:refname | head -n 1)
 VERSION=$(subst go/adbc/,,$(GIT_VERSION))
 
-DRIVERS := \
-	libadbc_driver_bigquery.$(SUFFIX) \
-	libadbc_driver_flightsql.$(SUFFIX) \
-	libadbc_driver_panicdummy.$(SUFFIX) \
-	libadbc_driver_snowflake.$(SUFFIX)
+# Expand dynamically libadbc_driver_.SUFFIX
+DRIVERS := $(addsuffix .$(SUFFIX),$(addprefix libadbc_driver_,$(MANAGERS)))

Review Comment:
   magic ✨ 



##########
go/adbc/pkg/Makefile:
##########
@@ -14,8 +14,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-GO_BUILD=go build
-RM=rm -f
+MANAGERS = bigquery flightsql panicdummy snowflake

Review Comment:
   as in Database MANAGEMENT Systems? :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make now considers more source files as dependencies [arrow-adbc]

Posted by "VersusFacit (via GitHub)" <gi...@apache.org>.
VersusFacit closed pull request #3108: Make now considers more source files as dependencies
URL: https://github.com/apache/arrow-adbc/pull/3108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org