You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2015/12/24 06:52:35 UTC

[GitHub] incubator-zeppelin pull request: Keep paragraph height unchanged w...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/568

    Keep paragraph height unchanged when progress bar is shown

    ### What is this PR for?
    Paragraph height is changing depends on progress bar.
    This PR make paragraph height unchanged whether progress bar is shown or not.
    
    ### What type of PR is it?
    Bug Fix
    
    ### How should this be tested?
    Run paragraph and see progress bar change it's height.
    
    ### Screenshots (if appropriate)
    
    before
    ![paragraph_height_master](https://cloud.githubusercontent.com/assets/1540981/11990227/df7c7e1e-aa4d-11e5-8026-6d9eccac6500.gif)
    
    after
    ![paragraph_height](https://cloud.githubusercontent.com/assets/1540981/11990228/e1960ad0-aa4d-11e5-89bb-52cb56686267.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/incubator-zeppelin fixed_height

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/568.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #568
    
----
commit 76a7bf1775c222238c0a66b672dfd126f18f7ff8
Author: Lee moon soo <mo...@apache.org>
Date:   2015-12-24T05:49:16Z

    Let progress bar does not change paragraph height

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Keep paragraph height unchanged w...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/568#issuecomment-167274826
  
    Tested, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Keep paragraph height unchanged w...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/568


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Keep paragraph height unchanged w...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/568#issuecomment-167236410
  
    @Leemoonsoo Didn't we had the same PR before?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Keep paragraph height unchanged w...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/568#issuecomment-167257287
  
    @corneadoug Yes. But it broke again somehow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---