[GitHub] [samza] rmatharu commented on a change in pull request #1488: SAMZA-2646: Minor refactor of StreamAppender to support sending formats other than byte[] to SystemProducer

[GitBox <gi...@apache.org>]

rmatharu commented on a change in pull request #1488:
URL: https://github.com/apache/samza/pull/1488#discussion_r618740524



##########
File path: samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppender.java
##########
@@ -498,4 +498,42 @@ protected void setSerde(Log4jSystemConfig log4jSystemConfig, String systemName)
   public Serde<LogEvent> getSerde() {
     return serde;
   }
+
+  /**
+   * A LogQeueEntry is the element inserted into the log queue of the stream appender
+   * that holds the log messages before they are sent to the underlying system producer.
+   * @param <T> type of object held as the entry
+   */
+  protected interface EncodedLogEvent<T> {
+    /**
+     * fetches the size of the log message held within the LogQueueEntry
+     * @return size of the log message
+     */
+    public long getEntryValueSize();
+
+    /**
+     * fetches the actual log message held within the LogQueueEntry
+     * @return the actual log message
+     */
+    public T getValue();
+  }

Review comment:
       Why define an interface when there is only a single impl?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org