You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2013/06/24 20:55:37 UTC
[jclouds-labs-openstack] Rename reddwarf to trove (#10)
https://issues.apache.org/jira/browse/JCLOUDS-129
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack rename-reddwarf-trove
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/10
-- Commit Summary --
* Rename reddwarf to trove
-- File Changes --
R openstack-trove/pom.xml (28)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/TroveApi.java (14)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/TroveApiMetadata.java (30)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/binders/BindCreateDatabaseToJson.java (2)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/binders/BindCreateInstanceToJson.java (4)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/binders/BindCreateUserToJson.java (6)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/binders/BindGrantUserToJson.java (2)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/config/TroveHttpApiModule.java (16)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/config/TroveParserModule.java (4)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/Flavor.java (4)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/Instance.java (8)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/User.java (4)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/features/DatabaseApi.java (6)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/features/FlavorApi.java (6)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/features/InstanceApi.java (10)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/features/UserApi.java (12)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/functions/ParseDatabaseListForUser.java (2)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/functions/ParsePasswordFromRootedInstance.java (2)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/handlers/TroveErrorHandler.java (4)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/internal/Volume.java (2)
R openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/predicates/InstancePredicates.java (8)
R openstack-trove/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata (2)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/domain/FlavorTest.java (2)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/domain/InstanceTest.java (2)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/domain/UserTest.java (2)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/DatabaseApiExpectTest.java (6)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/DatabaseApiLiveTest.java (10)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/FlavorApiExpectTest.java (12)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/FlavorApiLiveTest.java (8)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/InstanceApiExpectTest.java (8)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/InstanceApiLiveTest.java (10)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/UserApiExpectTest.java (12)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/UserApiLiveTest.java (24)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/internal/BaseTroveApiExpectTest.java (6)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/internal/BaseTroveApiLiveTest.java (12)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/internal/BaseTroveExpectTest.java (8)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/parse/ParseFlavorListTest.java (4)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/parse/ParseInstanceListTest.java (6)
R openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/parse/ParseUserListTest.java (6)
R openstack-trove/src/test/resources/access_rax_us.json (0)
R openstack-trove/src/test/resources/database_create_request.json (0)
R openstack-trove/src/test/resources/database_create_simple_request.json (0)
R openstack-trove/src/test/resources/database_list.json (0)
R openstack-trove/src/test/resources/flavor_get.json (0)
R openstack-trove/src/test/resources/flavor_list.json (0)
R openstack-trove/src/test/resources/instance_create.json (0)
R openstack-trove/src/test/resources/instance_create_request.json (0)
R openstack-trove/src/test/resources/instance_get.json (0)
R openstack-trove/src/test/resources/instance_is_rooted.json (0)
R openstack-trove/src/test/resources/instance_is_rooted_false.json (0)
R openstack-trove/src/test/resources/instance_list.json (0)
R openstack-trove/src/test/resources/instance_root.json (0)
R openstack-trove/src/test/resources/logback-test.xml (0)
R openstack-trove/src/test/resources/logback.xml (0)
R openstack-trove/src/test/resources/trove_user_list.json (0)
R openstack-trove/src/test/resources/user_create_request.json (0)
R openstack-trove/src/test/resources/user_create_simple_request.json (0)
R openstack-trove/src/test/resources/user_create_with_host_simple_request.json (0)
R openstack-trove/src/test/resources/user_get.json (0)
R openstack-trove/src/test/resources/user_get_withhost.json (0)
R openstack-trove/src/test/resources/user_grant_request.json (0)
R openstack-trove/src/test/resources/user_grant_simple_request.json (0)
R openstack-trove/src/test/resources/user_list_access.json (0)
R openstack-trove/src/test/resources/user_password_request.json (0)
M pom.xml (2)
M rackspace-clouddatabases-uk/pom.xml (8)
M rackspace-clouddatabases-uk/src/main/java/org/jclouds/rackspace/clouddatabases/uk/CloudDatabasesUKProviderMetadata.java (12)
M rackspace-clouddatabases-uk/src/test/java/org/jclouds/rackspace/clouddatabases/uk/CloudDatabasesUKProviderMetadataExpectTest.java (8)
M rackspace-clouddatabases-uk/src/test/java/org/jclouds/rackspace/clouddatabases/uk/CloudDatabasesUKProviderTest.java (4)
M rackspace-clouddatabases-uk/src/test/java/org/jclouds/rackspace/clouddatabases/uk/features/CloudDatabasesUKDatabaseApiLiveTest.java (2)
M rackspace-clouddatabases-uk/src/test/java/org/jclouds/rackspace/clouddatabases/uk/features/CloudDatabasesUKFlavorApiLiveTest.java (2)
M rackspace-clouddatabases-uk/src/test/java/org/jclouds/rackspace/clouddatabases/uk/features/CloudDatabasesUKInstanceApiLiveTest.java (2)
M rackspace-clouddatabases-uk/src/test/java/org/jclouds/rackspace/clouddatabases/uk/features/CloudDatabasesUKUserApiLiveTest.java (2)
M rackspace-clouddatabases-us/pom.xml (8)
M rackspace-clouddatabases-us/src/main/java/org/jclouds/rackspace/clouddatabases/us/CloudDatabasesUSProviderMetadata.java (12)
M rackspace-clouddatabases-us/src/test/java/org/jclouds/rackspace/clouddatabases/us/CloudDatabasesUSProviderMetadataExpectTest.java (8)
M rackspace-clouddatabases-us/src/test/java/org/jclouds/rackspace/clouddatabases/us/CloudDatabasesUSProviderTest.java (4)
M rackspace-clouddatabases-us/src/test/java/org/jclouds/rackspace/clouddatabases/us/features/CloudDatabasesUSDatabaseApiLiveTest.java (2)
M rackspace-clouddatabases-us/src/test/java/org/jclouds/rackspace/clouddatabases/us/features/CloudDatabasesUSFlavorApiLiveTest.java (2)
M rackspace-clouddatabases-us/src/test/java/org/jclouds/rackspace/clouddatabases/us/features/CloudDatabasesUSInstanceApiLiveTest.java (2)
M rackspace-clouddatabases-us/src/test/java/org/jclouds/rackspace/clouddatabases/us/features/CloudDatabasesUSUserApiLiveTest.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/10.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/10.diff
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-openstack #131](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/131/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10#issuecomment-19928019
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Andrew Phillips <no...@github.com>.
> @@ -25,12 +25,12 @@
> <version>1.7.0-SNAPSHOT</version>
> </parent>
>
> - <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when RedDwarf is moved to jclouds -->
> + <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when Trove is moved to jclouds -->
>
> <groupId>org.apache.jclouds.provider</groupId>
See e.g. [fgcp-au](https://github.com/jclouds/jclouds-labs/blob/master/fgcp-au/pom.xml#L29)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10/files#r4851991
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Ignasi Barrera <no...@github.com>.
+1 this looks good to me. I'd address the groupId thing in a separate pull request.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10#issuecomment-19930869
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -25,12 +25,12 @@
> <version>1.7.0-SNAPSHOT</version>
> </parent>
>
> - <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when RedDwarf is moved to jclouds -->
> + <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when Trove is moved to jclouds -->
>
> <groupId>org.apache.jclouds.provider</groupId>
I know this is not part of the commit, but I've just seen it. Providers in labs have the `org.apache.jclouds.labs` groupId. Should the clouddatabases providers be changed to follow the same convention?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10/files#r4849984
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Everett Toews <no...@github.com>.
Merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10#issuecomment-20011514
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -25,12 +25,12 @@
> <version>1.7.0-SNAPSHOT</version>
> </parent>
>
> - <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when RedDwarf is moved to jclouds -->
> + <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when Trove is moved to jclouds -->
>
> <groupId>org.apache.jclouds.provider</groupId>
Currently other providers and apis use just `org.apache.jclouds.labs`. I like more the one you suggest Zach, but I'd discuss that in the dev mailing list and change all labs providers/apis at once :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10/files#r4850722
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Zack Shoylev <no...@github.com>.
> @@ -25,12 +25,12 @@
> <version>1.7.0-SNAPSHOT</version>
> </parent>
>
> - <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when RedDwarf is moved to jclouds -->
> + <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when Trove is moved to jclouds -->
>
> <groupId>org.apache.jclouds.provider</groupId>
Do you mean org.apache.jclouds.labs.provider
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10/files#r4850589
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Zack Shoylev <no...@github.com>.
> @@ -25,12 +25,12 @@
> <version>1.7.0-SNAPSHOT</version>
> </parent>
>
> - <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when RedDwarf is moved to jclouds -->
> + <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when Trove is moved to jclouds -->
>
> <groupId>org.apache.jclouds.provider</groupId>
As long as it is consistent across code, I will be happy changing it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10/files#r4851648
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Everett Toews <no...@github.com>.
Closed #10.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10
Re: [jclouds-labs-openstack] Rename reddwarf to trove (#10)
Posted by Andrew Phillips <no...@github.com>.
> @@ -25,12 +25,12 @@
> <version>1.7.0-SNAPSHOT</version>
> </parent>
>
> - <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when RedDwarf is moved to jclouds -->
> + <!-- TODO: when out of labs, switch to org.jclouds.provider; update dependencies when Trove is moved to jclouds -->
>
> <groupId>org.apache.jclouds.provider</groupId>
+1 - this should definitely be `org.apache.jclouds.labs`. In fact, the comment could do with a small update (org.jclouds -> org.apache.jclouds) too ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/10/files#r4850524