[GitHub] spark pull request: [SPARK-12331][ML] R^2 for regression through t...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10384#discussion_r48692216
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala ---
    @@ -27,11 +27,17 @@ import org.apache.spark.sql.DataFrame
     /**
      * Evaluator for regression.
      *
    - * @param predictionAndObservations an RDD of (prediction, observation) pairs.
    + * @param predictionAndObservations an RDD of (prediction, observation) pairs,
    + * @param throughOrigin True if the regression is through the origin. For example, in linear
    + *                      regression, it will be true without fitting intercept.
      */
     @Since("1.2.0")
     class RegressionMetrics @Since("1.2.0") (
    -    predictionAndObservations: RDD[(Double, Double)]) extends Logging {
    +    predictionAndObservations: RDD[(Double, Double)], throughOrigin: Boolean)
    --- End diff --
    
    @iyounus ah we have two tiny problems to sort then this can be merged. First the `@Since` annotation is wrong here; it needs to move to the new constructor, and this needs a new "since 2.0.0" annotation on the main constructor. Also, in the scaladoc, `predictionAndObservations` ends with a comma now but should be left unchanged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org