You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ad...@apache.org on 2023/06/01 09:24:31 UTC
[maven-pmd-plugin] 12/13: Remove deprecated usages
This is an automated email from the ASF dual-hosted git repository.
adangel pushed a commit to branch pmd7
in repository https://gitbox.apache.org/repos/asf/maven-pmd-plugin.git
commit 67dd07a831e573d141a8cc48707587f98fe94c90
Author: Andreas Dangel <ad...@apache.org>
AuthorDate: Sat May 20 10:46:12 2023 +0200
Remove deprecated usages
---
.../java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java | 7 ++-----
.../java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java | 10 ++++++----
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/main/java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java b/src/main/java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java
index ad0a5d3..55f069b 100644
--- a/src/main/java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java
+++ b/src/main/java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java
@@ -155,8 +155,8 @@ public class PmdExecutor extends Executor {
PMDConfiguration configuration = new PMDConfiguration();
LanguageVersion languageVersion = null;
- Language language = LanguageRegistry.findLanguageByTerseName(
- request.getLanguage() != null ? request.getLanguage() : "java");
+ Language language =
+ LanguageRegistry.PMD.getLanguageById(request.getLanguage() != null ? request.getLanguage() : "java");
if (language == null) {
throw new MavenReportException("Unsupported language: " + request.getLanguage());
}
@@ -189,9 +189,6 @@ public class PmdExecutor extends Executor {
configuration.setRuleSets(request.getRulesets());
configuration.setMinimumPriority(RulePriority.valueOf(request.getMinimumPriority()));
- if (request.getBenchmarkOutputLocation() != null) {
- configuration.setBenchmark(true);
- }
List<File> files = request.getFiles();
Report report = null;
diff --git a/src/test/java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java b/src/test/java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java
index fadd719..67f48e1 100644
--- a/src/test/java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java
+++ b/src/test/java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java
@@ -23,11 +23,13 @@ import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
-import junit.framework.Assert;
-import junit.framework.TestCase;
import org.apache.commons.lang3.SystemUtils;
+import org.junit.Test;
-public class ExecutorTest extends TestCase {
+import static org.junit.Assert.assertEquals;
+
+public class ExecutorTest {
+ @Test
public void testBuildClasspath() throws MalformedURLException {
String basename = "home/test/dir with space/mylib.jar";
String pathname = new File("/", basename).getPath();
@@ -39,6 +41,6 @@ public class ExecutorTest extends TestCase {
StringBuilder classpath = new StringBuilder();
Executor.buildClasspath(classpath, mockedClassLoader);
- Assert.assertEquals(pathname + File.pathSeparator, classpath.toString());
+ assertEquals(pathname + File.pathSeparator, classpath.toString());
}
}