You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/09/12 20:34:30 UTC
[Bug 5098] New: Add ecelerity received header format to the Received module
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
Summary: Add ecelerity received header format to the Received
module
Product: Spamassassin
Version: 3.1.5
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: felicity@apache.org
>From Joe Schaefer <jo...@sunstarsys.com> to the dev@ list:
Could someone add the following code to the the parse_received_headers
sub in the Mail::SpamAssassin::Message::Metadata::Received module?
if (/ecelerity /) {
if (/^from \(\[(${IP_ADDRESS}):\d+\] helo=(\S+)\) by (\S+)/) {
$ip = $1; $helo = $2; $by = $3;
/ id (\S+)/ and $id = $1;
goto enough;
}
}
The code tries to parse the ecelerity Received: headers, which
apparently to exotic to be parsed using the default rules. When
added at line 419, it seems to fix the ALL_TRUSTED misfires for
the ASF's frontline MX.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
------- Additional Comments From jm@jmason.org 2006-09-13 08:24 -------
oh, also, if the rdns is recorded at any time, that would be cool to know.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
------- Additional Comments From jm@jmason.org 2006-09-12 19:28 -------
recording the envelope-sender would be nice, too! Joe, does it support that?
Any chance you could add that to the ASF config?
(If the env sender is recorded in the Received header for that SMTP transaction,
it allows SA to look up SPF records a lot more reliably.)
in as r442679; patch for 3.1.x to follow.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.1.6
------- Additional Comments From felicity@apache.org 2006-09-12 18:47 -------
Some header examples from my corpus: Apparently ecelerity lets people configure
the Received header... We may want to ask Theo Schlossnagle about this since
his company wrote ecelerity, and he's involved with the ASF (which is why this
came up in the first place... :))
Received: from ([192.168.1.205:50387] helo=i6.prod.democracyinaction.com)
by m12.prod.democracyinaction.com (ecelerity 2.1.1.3 r(11743)) with ESMTP
id 80/0A-02454-4DCB6054 for <ex...@vandinter.org>; Tue, 12 Sep 2006
09:57:40 -0400
Received: from [127.0.0.1] ([127.0.0.1:50024])
by bm1-13.ed10.com (ecelerity 2.1.1.8 r(12431)) with ECSTREAM
id 10/BD-03444-F4DB6054 for <ex...@vandinter.org>; Tue, 12 Sep 2006
09:59:43 -0400
Received: from ([67.91.233.27:53798] helo=eclectic.kluge.net)
by idunn.apache.osuosl.org (ecelerity 2.1 r(10620)) with ESMTP
id 5A/F0-04030-76FF6054 for <de...@spamassassin.apache.org>; Tue, 12 Sep
2006 11:41:44 -0700
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
wez@omniti.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wez@omniti.com
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
------- Additional Comments From jm@jmason.org 2006-10-02 09:17 -------
Joe says:
> It doesn't look to me like ecelerity puts that info in the headers.
> I also don't see any documented configuration options to modify
> the behavior.
I said:
if it comes up later, feel free to let us know of the formats.
It would be good to capture that info -- helps a lot for SPF and
some other rules.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
------- Additional Comments From jm@jmason.org 2006-09-12 19:29 -------
Created an attachment (id=3694)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3694&action=view)
patch for 3.1.x
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
------- Additional Comments From wez@omniti.com 2006-10-05 14:09 -------
(I'm lead developer for ecelerity)
Just letting you know that we've been making our Received header a bit more
conformant recently; the following will be emerging with our 2.2 release:
Received: from [1.2.3.4] ([5.6.7.8:1247] helo=[5.6.7.8])
by jc.netevil.org (envelope-from <fo...@example.com>)
(ecelerity 2.x.y.z r(11743)) with ESMTP
id F7/10-01577-573A1F44 for <we...@thebrainroom.com>; Sun, 27 Aug 2006 06:52:01 -0700
the "from-domain" IP address is present in our latest 2.1 releases, the
envelope-from comment (as detailed in
http://wiki.apache.org/spamassassin/EnvelopeSenderInReceived) will be available
from 2.2 onwards.
I'm hoping that the changes you've already made in this ticket will not collide
badly with our updates--it looks like you'll fall through to a generic RFC
compliant case so I think it'll be ok.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |go
------- Additional Comments From spamassassin@dostech.ca 2006-09-18 06:05 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- Additional Comments From felicity@apache.org 2006-09-17 04:31 -------
sure. +1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add ecelerity received |[review] Add ecelerity
|header format to the |received header format to
|Received module |the Received module
Status Whiteboard| |needs 2 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
------- Additional Comments From spamassassin@dostech.ca 2006-09-29 12:47 -------
(In reply to comment #2)
> recording the envelope-sender would be nice, too! Joe, does it support that?
> Any chance you could add that to the ASF config?
(In reply to comment #4)
> oh, also, if the rdns is recorded at any time, that would be cool to know.
Has anyone heard from Joe (has Joe even seen this, he's not copied)? Or are we
happy with the patch as is for 3.1.6?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5098] [review] Add ecelerity received header format to the Received module
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5098
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2006-10-02 10:01 -------
thanks :)
[dos@FC5-VPC 3.1]$ svn ci -m "bug 5098: add support for ecelerity Received
headers, thanks to Joe Schaefer <joe+gmane at sunstarsys.com>"
Sending lib/Mail/SpamAssassin/Message/Metadata/Received.pm
Sending t/rcvd_parser.t
Transmitting file data ..
Committed revision 452120.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.