You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/13 03:17:28 UTC

[GitHub] [pulsar] jiazhai commented on a change in pull request #4258: [pulsar-io] hbase sink use BooleanSchema encode Boolean data

jiazhai commented on a change in pull request #4258: [pulsar-io] hbase sink use BooleanSchema encode Boolean data
URL: https://github.com/apache/pulsar/pull/4258#discussion_r283177001
 
 

 ##########
 File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java
 ##########
 @@ -38,12 +36,9 @@
 @EqualsAndHashCode
 @ToString
 @Accessors(chain = true)
-public class HbaseAbstractConfig implements Serializable {
 
 Review comment:
   better to keep  Serializable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services