You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (Created) (JIRA)" <ji...@apache.org> on 2012/04/05 20:30:25 UTC
[jira] [Created] (HBASE-5731) Make max line length 100 in linter
Make max line length 100 in linter
----------------------------------
Key: HBASE-5731
URL: https://issues.apache.org/jira/browse/HBASE-5731
Project: HBase
Issue Type: New Feature
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Priority: Minor
We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5731) Make max line length 100 in linter
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5731:
-------------------------------
Attachment: D2631.1.patch
mbautin requested code review of "[jira] [HBASE-5731] Make max line length 100 in linter".
Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack
We have switched to 100 characters per line in our Java files. Making the change in the linter. The 89-fb version is D2625.
TEST PLAN
arc lint
REVISION DETAIL
https://reviews.facebook.net/D2631
AFFECTED FILES
.arcconfig
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6045/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch, D2631.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5731) Make max line length 100 in linter
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247483#comment-13247483 ]
Phabricator commented on HBASE-5731:
------------------------------------
tedyu has accepted the revision "[jira] [HBASE-5731] [89-fb] Make max line length 100 in linter".
REVISION DETAIL
https://reviews.facebook.net/D2625
BRANCH
master
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5731) Make max line length 100 in linter
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247668#comment-13247668 ]
Hudson commented on HBASE-5731:
-------------------------------
Integrated in HBase-TRUNK-security #158 (See [https://builds.apache.org/job/HBase-TRUNK-security/158/])
[jira] [HBASE-5731] Make max line length 100 in linter
Summary: We have switched to 100 characters per line in our Java files. Making
the change in the linter. The 89-fb version is D2625.
Test Plan: arc lint
Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack
Reviewed By: Kannan
Differential Revision: https://reviews.facebook.net/D2631 (Revision 1310006)
Result = FAILURE
mbautin :
Files :
* /hbase/trunk/.arcconfig
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch, D2631.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5731) Make max line length 100 in linter
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247493#comment-13247493 ]
Phabricator commented on HBASE-5731:
------------------------------------
stack has commented on the revision "[jira] [HBASE-5731] Make max line length 100 in linter".
+1
REVISION DETAIL
https://reviews.facebook.net/D2631
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch, D2631.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5731) Make max line length 100 in linter
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5731:
-------------------------------
Attachment: D2625.1.patch
mbautin requested code review of "[jira] [HBASE-5731] [89-fb] Make max line length 100 in linter".
Reviewers: JIRA, nspiegelberg, Kannan, tedyu, stack
We have switched to 100 characters per line in our Java files. Making the change in the linter.
TEST PLAN
arc lint
REVISION DETAIL
https://reviews.facebook.net/D2625
AFFECTED FILES
.arcconfig
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6039/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5731) Make max line length 100 in linter
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247505#comment-13247505 ]
Phabricator commented on HBASE-5731:
------------------------------------
mbautin has committed the revision "[jira] [HBASE-5731] [89-fb] Make max line length 100 in linter".
REVISION DETAIL
https://reviews.facebook.net/D2625
COMMIT
https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1310000
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch, D2631.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5731) Make max line length 100 in linter
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247555#comment-13247555 ]
Hudson commented on HBASE-5731:
-------------------------------
Integrated in HBase-TRUNK #2713 (See [https://builds.apache.org/job/HBase-TRUNK/2713/])
[jira] [HBASE-5731] Make max line length 100 in linter
Summary: We have switched to 100 characters per line in our Java files. Making
the change in the linter. The 89-fb version is D2625.
Test Plan: arc lint
Reviewers: JIRA, nspiegelberg, Kannan, Liyin, tedyu, stack
Reviewed By: Kannan
Differential Revision: https://reviews.facebook.net/D2631 (Revision 1310006)
Result = SUCCESS
mbautin :
Files :
* /hbase/trunk/.arcconfig
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch, D2631.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5731) Make max line length 100 in linter
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247504#comment-13247504 ]
Phabricator commented on HBASE-5731:
------------------------------------
Kannan has accepted the revision "[jira] [HBASE-5731] Make max line length 100 in linter".
REVISION DETAIL
https://reviews.facebook.net/D2631
BRANCH
linter_100chars
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch, D2631.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5731) Make max line length 100 in linter
Posted by "Mikhail Bautin (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin resolved HBASE-5731.
-----------------------------------
Resolution: Fixed
Committed in 89-fb and trunk.
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch, D2631.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5731) Make max line length 100 in linter
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247519#comment-13247519 ]
Phabricator commented on HBASE-5731:
------------------------------------
mbautin has committed the revision "[jira] [HBASE-5731] Make max line length 100 in linter".
REVISION DETAIL
https://reviews.facebook.net/D2631
COMMIT
https://reviews.facebook.net/rHBASE1310006
> Make max line length 100 in linter
> ----------------------------------
>
> Key: HBASE-5731
> URL: https://issues.apache.org/jira/browse/HBASE-5731
> Project: HBase
> Issue Type: New Feature
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2625.1.patch, D2631.1.patch
>
>
> We have switched to 100 characters per line in our Java files. Making the change in the linter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira