You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jwilliams-ocient (via GitHub)" <gi...@apache.org> on 2023/04/20 15:45:56 UTC
[GitHub] [superset] jwilliams-ocient opened a new pull request, #23755: chore: write access request for jwilliams-ocient
jwilliams-ocient opened a new pull request, #23755:
URL: https://github.com/apache/superset/pull/23755
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I'm currently working on #22812 and am requesting write access to kick off CI runs without bugging the superset team 🙃 .
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient closed pull request #23755: chore: write access request for jwilliams-ocient
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient closed pull request #23755: chore: write access request for jwilliams-ocient
URL: https://github.com/apache/superset/pull/23755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on pull request #23755: chore: write access request for jwilliams-ocient
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on PR #23755:
URL: https://github.com/apache/superset/pull/23755#issuecomment-1517076587
Thanks @rusackas! I went ahead and read the _very thorough_ contribution guidelines (duh!) which clearly outline how to run the pre-commit checks locally. They pass on my end, hoping we're ready to ship after the next CI run. 🤞🏾
Apologies for the context switch, and thanks for your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on pull request #23755: chore: write access request for jwilliams-ocient
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on PR #23755:
URL: https://github.com/apache/superset/pull/23755#issuecomment-1517077430
I'll go ahead and close this PR and ping you directly on #22812 if the next CI run fails 🙃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23755: chore: write access request for jwilliams-ocient
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23755:
URL: https://github.com/apache/superset/pull/23755#issuecomment-1516909831
Interesting approach :)
We can't grant write access to the repo. Only Apache does that once you've been voted in as a committer.
I just re-ran the failing E2E tests on your PR to see if it passes this time, so hopefully we can merge that shortly. Nag me here or on Slack if it needs to be kicked again.
I'd rather merge that PR than clutter the changelog with this (or who knows how many others who use the same technique). Either way, you should be free of that approval burden once your first PR merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23755: chore: write access request for jwilliams-ocient
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23755:
URL: https://github.com/apache/superset/pull/23755#issuecomment-1518916462
Sorry for the flaky test headaches... There's a lot of effort ahead on that front. Thanks again for the contribution - it's merged!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org