[GitHub] [iceberg] stevenzwu commented on a change in pull request #2566: Flink : vectorized read of orc format in flink

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #2566:
URL: https://github.com/apache/iceberg/pull/2566#discussion_r629837699



##########
File path: flink/src/main/java/org/apache/iceberg/flink/data/FlinkOrcReaders.java
##########
@@ -49,19 +49,19 @@
 import org.apache.orc.storage.ql.exec.vector.TimestampColumnVector;
 import org.apache.orc.storage.serde2.io.HiveDecimalWritable;
 
-class FlinkOrcReaders {
+public class FlinkOrcReaders {
   private FlinkOrcReaders() {
   }
 
-  static OrcValueReader<StringData> strings() {
+  public static OrcValueReader<StringData> strings() {

Review comment:
       curious why only making these 3 public. what about other package scope methods like `times`, `timestamps`, `array`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org