You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/22 01:56:42 UTC
[GitHub] [doris] mychaow opened a new pull request, #11101: fix some docs issue
mychaow opened a new pull request, #11101:
URL: https://github.com/apache/doris/pull/11101
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
developer guide has some problem about install third-party depencies about openssl
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #11101: [doc] fix some docs issue
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #11101:
URL: https://github.com/apache/doris/pull/11101#discussion_r928450479
##########
docs/zh-CN/developer/developer-guide/be-vscode-dev.md:
##########
@@ -49,10 +49,10 @@ sudo apt install gcc-10 g++-10
sudo apt-get install autoconf automake libtool autopoint
```
-4. 安装 openssl-devel
+4. 安装 openssl libssl-dev
```
-sudo apt install -y openssl-devel
+sudo apt install openssl libssl-dev
Review Comment:
```suggestion
sudo apt install -y openssl libssl-dev
```
##########
docs/en/developer/developer-guide/be-vscode-dev.md:
##########
@@ -48,9 +48,9 @@ sudo apt install gcc-10 g++-10
sudo apt-get install autoconf automake libtool autopoint
```
-4. install : libssl-dev
+4. install : openssl libssl-dev
```
-sudo apt install -y libssl-dev
+sudo apt install openssl libssl-dev
Review Comment:
It is better to keep `-y` argument to run the command without interaction.
```suggestion
sudo apt install -y openssl libssl-dev
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hf200012 commented on pull request #11101: [doc] fix some docs issue
Posted by GitBox <gi...@apache.org>.
hf200012 commented on PR #11101:
URL: https://github.com/apache/doris/pull/11101#issuecomment-1199023958
@mychaow rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #11101: [doc] fix some docs issue
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #11101:
URL: https://github.com/apache/doris/pull/11101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11101: [doc] fix some docs issue
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11101:
URL: https://github.com/apache/doris/pull/11101#issuecomment-1192112991
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11101: [doc] fix some docs issue
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11101:
URL: https://github.com/apache/doris/pull/11101#issuecomment-1235483145
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org