You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/03/24 01:24:41 UTC
Review Request 45255: PXF should use hostname instead of localhost in
pxf urls
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45255/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, jun aoki, Jonathan Hurley, Jayush Luniya, and Oleksandr Diachenko.
Bugs: AMBARI-15550
https://issues.apache.org/jira/browse/AMBARI-15550
Repository: ambari
Description
-------
PXF should use actual hostname instead of localhost in pxf urls.
Diffs
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py 3134f41
Diff: https://reviews.apache.org/r/45255/diff/
Testing
-------
yes. manually
Thanks,
bhuvnesh chaudhary
Re: Review Request 45255: PXF should use hostname instead of
localhost in pxf urls
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45255/#review125202
-----------------------------------------------------------
Ship it!
Ship It!
- Goutam Tadi
On March 24, 2016, 12:24 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45255/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:24 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jonathan Hurley, Jayush Luniya, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15550
> https://issues.apache.org/jira/browse/AMBARI-15550
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PXF should use actual hostname instead of localhost in pxf urls.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py 3134f41
>
> Diff: https://reviews.apache.org/r/45255/diff/
>
>
> Testing
> -------
>
> yes. manually
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 45255: PXF should use hostname instead of
localhost in pxf urls
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45255/#review125206
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Denissov
On March 24, 2016, 12:24 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45255/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:24 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jonathan Hurley, Jayush Luniya, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15550
> https://issues.apache.org/jira/browse/AMBARI-15550
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PXF should use actual hostname instead of localhost in pxf urls.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py 3134f41
>
> Diff: https://reviews.apache.org/r/45255/diff/
>
>
> Testing
> -------
>
> yes. manually
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 45255: PXF should use hostname instead of
localhost in pxf urls
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
> On March 24, 2016, 4:49 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 136
> > <https://reviews.apache.org/r/45255/diff/1/?file=1312736#file1312736line136>
> >
> > Did anything break when it was localhost?
> >
> > Would be surprised if it caused any issue.
none breaks, the host listens on all the interface, but generally its better to listen on hostname rather than localhost.
- bhuvnesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45255/#review125212
-----------------------------------------------------------
On March 24, 2016, 12:24 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45255/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:24 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jonathan Hurley, Jayush Luniya, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15550
> https://issues.apache.org/jira/browse/AMBARI-15550
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PXF should use actual hostname instead of localhost in pxf urls.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py 3134f41
>
> Diff: https://reviews.apache.org/r/45255/diff/
>
>
> Testing
> -------
>
> yes. manually
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 45255: PXF should use hostname instead of
localhost in pxf urls
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45255/#review125212
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 134)
<https://reviews.apache.org/r/45255/#comment188000>
Did anything break when it was localhost?
Would be surprised if it caused any issue.
- Matt
On March 23, 2016, 5:24 p.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45255/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 5:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jonathan Hurley, Jayush Luniya, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15550
> https://issues.apache.org/jira/browse/AMBARI-15550
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PXF should use actual hostname instead of localhost in pxf urls.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py 3134f41
>
> Diff: https://reviews.apache.org/r/45255/diff/
>
>
> Testing
> -------
>
> yes. manually
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>