You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/03/06 14:11:02 UTC
Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to
cover non-shared PV.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813
Repository: mesos
Description
-------
Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.
Diffs
-----
src/tests/persistent_volume_tests.cpp 8a5672ef117f64c173113df903d9e62bef7253f1
Diff: https://reviews.apache.org/r/70140/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes
to cover non-shared PV.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/#review213485
-----------------------------------------------------------
Bad review!
Reviews applied: [70140, 70139, 70138, 70137]
Error:
2019-03-06 14:14:37 URL:https://reviews.apache.org/r/70139/diff/raw/ [3304/3304] -> "70139.patch" [1]
error: patch failed: src/tests/containerizer/linux_filesystem_isolator_tests.cpp:1318
error: src/tests/containerizer/linux_filesystem_isolator_tests.cpp: patch does not apply
- Mesos Reviewbot
On March 6, 2019, 10:11 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70140/
> -----------------------------------------------------------
>
> (Updated March 6, 2019, 10:11 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 8a5672ef117f64c173113df903d9e62bef7253f1
>
>
> Diff: https://reviews.apache.org/r/70140/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes
to cover non-shared PV.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/#review213493
-----------------------------------------------------------
Bad review!
Reviews applied: [70140, 70139, 70138, 70137]
Error:
2019-03-06 17:20:49 URL:https://reviews.apache.org/r/70139/diff/raw/ [3304/3304] -> "70139.patch" [1]
error: patch failed: src/tests/containerizer/linux_filesystem_isolator_tests.cpp:1318
error: src/tests/containerizer/linux_filesystem_isolator_tests.cpp: patch does not apply
- Mesos Reviewbot
On March 6, 2019, 2:36 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70140/
> -----------------------------------------------------------
>
> (Updated March 6, 2019, 2:36 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 8a5672ef117f64c173113df903d9e62bef7253f1
>
>
> Diff: https://reviews.apache.org/r/70140/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes
to cover non-shared PV.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/
-----------------------------------------------------------
(Updated March 7, 2019, 4:57 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9641
https://issues.apache.org/jira/browse/MESOS-9641
Repository: mesos
Description
-------
Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.
Diffs
-----
src/tests/persistent_volume_tests.cpp 8a5672ef117f64c173113df903d9e62bef7253f1
Diff: https://reviews.apache.org/r/70140/diff/2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes
to cover non-shared PV.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/#review213547
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 6, 2019, 6:36 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70140/
> -----------------------------------------------------------
>
> (Updated March 6, 2019, 6:36 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 8a5672ef117f64c173113df903d9e62bef7253f1
>
>
> Diff: https://reviews.apache.org/r/70140/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes
to cover non-shared PV.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70140/
-----------------------------------------------------------
(Updated March 6, 2019, 10:36 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813
Repository: mesos
Description
-------
Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp 8a5672ef117f64c173113df903d9e62bef7253f1
Diff: https://reviews.apache.org/r/70140/diff/2/
Changes: https://reviews.apache.org/r/70140/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang