You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/27 10:12:17 UTC
[GitHub] [incubator-doris] frwrdt opened a new pull request #3216: fix
'Filesystem closed' in broker load
frwrdt opened a new pull request #3216: fix 'Filesystem closed' in broker load
URL: https://github.com/apache/incubator-doris/pull/3216
fix bug in issue #3210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#3216: fix 'Filesystem closed' in broker load
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3216: fix 'Filesystem closed' in broker load
URL: https://github.com/apache/incubator-doris/pull/3216#discussion_r399165856
##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -383,6 +384,7 @@ public BrokerFileSystem getS3AFileSystem(String path, Map<String, String> proper
conf.set(FS_S3A_ACCESS_KEY, accessKey);
conf.set(FS_S3A_SECRET_KEY, secretKey);
conf.set(FS_S3A_ENDPOINT, endpoint);
+ conf.set("fs.s3a.impl.disable.cache", "true");
Review comment:
Please use constant value. Add add a comment to explain why need this config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] frwrdt commented on a change in pull request
#3216: fix 'Filesystem closed' in broker load
Posted by GitBox <gi...@apache.org>.
frwrdt commented on a change in pull request #3216: fix 'Filesystem closed' in broker load
URL: https://github.com/apache/incubator-doris/pull/3216#discussion_r399189773
##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -383,6 +384,7 @@ public BrokerFileSystem getS3AFileSystem(String path, Map<String, String> proper
conf.set(FS_S3A_ACCESS_KEY, accessKey);
conf.set(FS_S3A_SECRET_KEY, secretKey);
conf.set(FS_S3A_ENDPOINT, endpoint);
+ conf.set("fs.s3a.impl.disable.cache", "true");
Review comment:
If this property is not set to "true", FileSystem instance will be returned from cache which is not thread-safe and may cause 'Filesystem closed' exception when it is closed by other thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] frwrdt commented on a change in pull request
#3216: fix 'Filesystem closed' in broker load
Posted by GitBox <gi...@apache.org>.
frwrdt commented on a change in pull request #3216: fix 'Filesystem closed' in broker load
URL: https://github.com/apache/incubator-doris/pull/3216#discussion_r399200904
##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -383,6 +384,7 @@ public BrokerFileSystem getS3AFileSystem(String path, Map<String, String> proper
conf.set(FS_S3A_ACCESS_KEY, accessKey);
conf.set(FS_S3A_SECRET_KEY, secretKey);
conf.set(FS_S3A_ENDPOINT, endpoint);
+ conf.set("fs.s3a.impl.disable.cache", "true");
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3216:
fix 'Filesystem closed' in broker load
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3216: fix 'Filesystem closed' in broker load
URL: https://github.com/apache/incubator-doris/pull/3216#discussion_r399190835
##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -383,6 +384,7 @@ public BrokerFileSystem getS3AFileSystem(String path, Map<String, String> proper
conf.set(FS_S3A_ACCESS_KEY, accessKey);
conf.set(FS_S3A_SECRET_KEY, secretKey);
conf.set(FS_S3A_ENDPOINT, endpoint);
+ conf.set("fs.s3a.impl.disable.cache", "true");
Review comment:
@frwrdt
You should add this comment in the source file to let others known not just the reviewer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #3216: fix
'Filesystem closed' in broker load
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #3216: fix 'Filesystem closed' in broker load
URL: https://github.com/apache/incubator-doris/pull/3216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org