[GitHub] [hive] deniskuzZ commented on a change in pull request #1914: [WIP] HIVE-24445: Non blocking DROP table implementation

[GitBox <gi...@apache.org>]

deniskuzZ commented on a change in pull request #1914:
URL: https://github.com/apache/hive/pull/1914#discussion_r565112483



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/DropTableAnalyzer.java
##########
@@ -54,9 +55,11 @@ public void analyzeInternal(ASTNode root) throws SemanticException {
       outputs.add(new WriteEntity(table, WriteEntity.WriteType.DDL_EXCLUSIVE));
     }
 
+    TableName tName = TableName.fromString(tableName, null, null);
+
     boolean purge = (root.getFirstChildWithType(HiveParser.KW_PURGE) != null);
     ReplicationSpec replicationSpec = new ReplicationSpec(root);
-    DropTableDesc desc = new DropTableDesc(tableName, ifExists, purge, replicationSpec);
+    DropTableDesc desc = new DropTableDesc(tName, ifExists, purge, replicationSpec);

Review comment:
       why is this change? i do not see constructor that accepts TableName. https://github.com/apache/hive/blob/08fd61d70fd172a63ee03e52f8c11db4718ba43c/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/DropTableDesc.java#L41




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org