You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/05/13 07:32:14 UTC

[GitHub] [cassandra] bereng opened a new pull request #1006: Cassandra 16654 4.0

bereng opened a new pull request #1006:
URL: https://github.com/apache/cassandra/pull/1006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] adelapena commented on a change in pull request #1006: Cassandra 16654 4.0

Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #1006:
URL: https://github.com/apache/cassandra/pull/1006#discussion_r632425488



##########
File path: doc/source/development/testing.rst
##########
@@ -65,6 +65,11 @@ Long running tests
 
 Test that consume a significant amount of time during execution can be found in the ``test/long`` directory and executed as a regular JUnit test or standalone program. Except for the execution time, there’s nothing really special about them. However, ant will execute tests under ``test/long`` only when using the ``ant long-test`` target.
 
+Flaky tests
+-----------
+
+If a test is difficult to reproduce you can always use a shell loop, circle repeat strategy and similar solutions. At the junit level ``RepeatableRunner`` will let you run a junit class N times for convinience. On tests that are fast this is a much faster way to iterate than doing it at the shell level. Beware of tests that modify singleton state or similar as they won't work.

Review comment:
       ```suggestion
   If a test failure is difficult to reproduce you can always use a shell loop, circle repeat strategy and similar solutions. At the JUnit level ``RepeatableRunner`` will let you run a JUnit class N times for convenience. On tests that are fast this is a much faster way to iterate than doing it at the shell level. Beware of tests that modify singleton state or similar as they won't work.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng commented on pull request #1006: Cassandra 16654 4.0

Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1006:
URL: https://github.com/apache/cassandra/pull/1006#issuecomment-842096483


   CI [j11 ](https://app.circleci.com/pipelines/github/bereng/cassandra/296/workflows/511633c3-1d87-4a50-b9d6-0735f484810a) Unrelated failures
   CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/296/workflows/567fc3f7-04de-41f9-875f-11df4d394434)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng closed pull request #1006: Cassandra 16654 4.0

Posted by GitBox <gi...@apache.org>.
bereng closed pull request #1006:
URL: https://github.com/apache/cassandra/pull/1006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng commented on pull request #1006: Cassandra 16654 4.0

Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1006:
URL: https://github.com/apache/cassandra/pull/1006#issuecomment-842096483


   CI [j11 ](https://app.circleci.com/pipelines/github/bereng/cassandra/296/workflows/511633c3-1d87-4a50-b9d6-0735f484810a) Unrelated failures
   CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/296/workflows/567fc3f7-04de-41f9-875f-11df4d394434)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org