You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/02/08 17:26:00 UTC

[jira] [Commented] (IMPALA-9718) Remove pkg_resources.py from Impala/shell

    [ https://issues.apache.org/jira/browse/IMPALA-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686001#comment-17686001 ] 

ASF subversion and git services commented on IMPALA-9718:
---------------------------------------------------------

Commit eca34cc9817397f0d6935b72d37974fafda85426 in impala's branch refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=eca34cc98 ]

IMPALA-11892: Restore pkg_resources with Python 2

Impala's shell tarball used to include a copy of pkg_resources.py (from
setuptools); due to the Python version we use for packaging, all modules
with native libraries use pkg_resources to load the library. It was
removed in IMPALA-9718 because Impala's copy of pkg_resources didn't
work with Python 3.

Some platforms - RHEL 7 for Python 2, Ubuntu/Debian - don't install
setuptools by default as part of the python package, which causes
impala-shell to error with "ImportError: No module named pkg_resources".

Restores Impala's copy of pkg_resources.py to PYTHONPATH when running
impala-shell under Python 2. Omits it for Python 3 so we use updated
setuptools when available. python-setuptools will still be a manual
requirement with Python 3.

Testing
- manually confirmed impala-shell starts in Ubuntu 20.04 docker
  container after 'apt install python' (omits setuptools).
- manually confirmed impala-shell starts in Ubuntu 20.04 docker
  container after 'apt install python3-setuptools' (includes python).

Change-Id: I78c05bce75ecc68de2296b1c2e57cd3c17c3cb0a
Reviewed-on: http://gerrit.cloudera.org:8080/19467
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Remove pkg_resources.py from Impala/shell
> -----------------------------------------
>
>                 Key: IMPALA-9718
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9718
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Clients
>    Affects Versions: Impala 4.0.0
>            Reporter: David Knupp
>            Assignee: Michael Smith
>            Priority: Major
>             Fix For: Impala 4.2.0
>
>
> pkg_resources is available in the stdlib. There should be no need to bundle it with the shell.
> Our copy of pkg_resources.py doesn't work with Python 3.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org