[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3726: [SCB-2771]fix MicroserviceVersions concurrent access problem

["liubao68 (via GitHub)" <gi...@apache.org>]

liubao68 commented on code in PR #3726:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3726#discussion_r1153968161


##########
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java:
##########
@@ -109,13 +110,18 @@ public String getMicroserviceName() {
     return microserviceName;
   }
 
+  @VisibleForTesting
   public Map<String, MicroserviceVersion> getVersions() {
-    return versions;
+    synchronized (lock) {
+      return versions;
+    }
   }
 
   @SuppressWarnings("unchecked")
   public <T extends MicroserviceVersion> T getVersion(String serviceId) {
-    return (T) versions.get(serviceId);
+    synchronized (lock) {
+      return (T) versions.get(serviceId);

Review Comment:
   1.3.x do not clear version when set instances, is this modification necessary and can you reproduce the problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org