[GitHub] [doris] wangshuo128 commented on a diff in pull request #13601: [Feature](Nereids) Support join hint.

[GitBox <gi...@apache.org>]

wangshuo128 commented on code in PR #13601:
URL: https://github.com/apache/doris/pull/13601#discussion_r1004084822


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/RequestPropertyDeriver.java:
##########
@@ -128,25 +129,45 @@ public Void visitPhysicalLocalQuickSort(PhysicalLocalQuickSort<? extends Plan> s
 
     @Override
     public Void visitPhysicalHashJoin(PhysicalHashJoin<? extends Plan, ? extends Plan> hashJoin, PlanContext context) {
-        // for broadcast join
-        if (JoinUtils.couldBroadcast(hashJoin)) {
-            addToRequestPropertyToChildren(PhysicalProperties.ANY, PhysicalProperties.REPLICATED);
-        }
+        JoinHint hint = hashJoin.getHint();

Review Comment:
   Please help to check the change here, thanks~ @morrySnow 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org