You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by to...@apache.org on 2012/05/01 03:38:21 UTC

svn commit: r1332493 - in /hbase/branches/0.92: CHANGES.txt src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java

Author: todd
Date: Tue May  1 01:38:21 2012
New Revision: 1332493

URL: http://svn.apache.org/viewvc?rev=1332493&view=rev
Log:
HBASE-5908. TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan.

Modified:
    hbase/branches/0.92/CHANGES.txt
    hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java

Modified: hbase/branches/0.92/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/branches/0.92/CHANGES.txt?rev=1332493&r1=1332492&r2=1332493&view=diff
==============================================================================
--- hbase/branches/0.92/CHANGES.txt (original)
+++ hbase/branches/0.92/CHANGES.txt Tue May  1 01:38:21 2012
@@ -1099,6 +1099,7 @@ Release 0.90.7 - Unreleased
 
   BUG FIXES
    HBASE-5271  Result.getValue and Result.getColumnLatest return the wrong column (Ghais Issa)
+   HBASE-5908  TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog (Gregory Chanan)
 
 Release 0.90.6 - Unreleased
 

Modified: hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java?rev=1332493&r1=1332492&r2=1332493&view=diff
==============================================================================
--- hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java (original)
+++ hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java Tue May  1 01:38:21 2012
@@ -116,8 +116,6 @@ public class TestHLogSplit {
   @BeforeClass
   public static void setUpBeforeClass() throws Exception {
     TEST_UTIL.getConfiguration().
-            setBoolean("dfs.support.append", true);
-    TEST_UTIL.getConfiguration().
             setStrings("hbase.rootdir", hbaseDir.toString());
     TEST_UTIL.getConfiguration().
             setClass("hbase.regionserver.hlog.writer.impl",
@@ -1223,7 +1221,9 @@ public class TestHLogSplit {
 
     switch (corruption) {
       case APPEND_GARBAGE:
-        out = fs.append(path);
+        fs.delete(path, false);
+        out = fs.create(path);
+        out.write(corrupted_bytes);
         out.write("-----".getBytes());
         closeOrFlush(close, out);
         break;