You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Shvachko (Jira)" <ji...@apache.org> on 2020/07/14 01:09:00 UTC
[jira] [Commented] (HDFS-15404) ShellCommandFencer should expose
info about source
[ https://issues.apache.org/jira/browse/HDFS-15404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157059#comment-17157059 ]
Konstantin Shvachko commented on HDFS-15404:
--------------------------------------------
Hey [~vagarychen], reviewed latest patch. It looks good, except there are some checkstyle warnings.
Particularly, the only change in {{TestNodeFencer}} is adding an unused import.
For your question about tooling. I thought this change should not effect the case when only 2 HA NameNodes are used. So the existing tooling should work as before. Do you have a specific example when it can be broken for 2 NNs?
> ShellCommandFencer should expose info about source
> --------------------------------------------------
>
> Key: HDFS-15404
> URL: https://issues.apache.org/jira/browse/HDFS-15404
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-15404.001.patch, HDFS-15404.002.patch, HDFS-15404.003.patch, HDFS-15404.004.patch
>
>
> Currently the HA fencing logic in ShellCommandFencer exposes environment variable about only the fencing target. i.e. the $target_* variables as mentioned in this [document page|https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HDFSHighAvailabilityWithQJM.html]).
> But here only the fencing target variables are getting exposed. Sometimes it is useful to expose info about the fencing source node. One use case is would allow source and target node to identify themselves separately and run different commands/scripts.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org