You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 15:35:16 UTC
[GitHub] [arrow] rok opened a new pull request, #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
rok opened a new pull request, #14422:
URL: https://github.com/apache/arrow/pull/14422
This is to resolve [ARROW-18042](https://issues.apache.org/jira/browse/ARROW-18042).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1283124135
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285292779
Revision: dba9497e4a8051384ec88f0a033ff56f7aee0759
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ccd8f258a9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ccd8f258a9)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3288773234/jobs/5419512644)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285450455
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285217424
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285394502
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1281541830
Revision: bb559d45398cd770a91dfb47b1306af8e06823f4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9ea9874269](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9ea9874269)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/tree/actions-9ea9874269-github-java-jars)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1283154582
Revision: a8e6077bc96e71f2e208b35ed75315f6878a9295
Submitted crossbow builds: [ursacomputing/crossbow @ actions-04c42b3180](https://github.com/ursacomputing/crossbow/branches/all?query=actions-04c42b3180)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3277775705/jobs/5395431255)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285498099
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1279341745
https://issues.apache.org/jira/browse/ARROW-18042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285375639
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285567432
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285454249
Revision: 768376e3751b0595ef4693fb8b7c989ca3f6622a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-681d64ebbe](https://github.com/ursacomputing/crossbow/branches/all?query=actions-681d64ebbe)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3289538900/jobs/5421194486)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1283950562
Revision: e46c0790bc6ac19af471e81f6cbd016b07d2b4f3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9d73abceb5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9d73abceb5)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3281621966/jobs/5403889204)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285490655
Revision: c0ad6581543725c4e20a210009d9da05cf9d9596
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9678643e0a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9678643e0a)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3289733512/jobs/5421634867)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1282870334
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok closed pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok closed pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
URL: https://github.com/apache/arrow/pull/14422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285737248
Revision: c0ad6581543725c4e20a210009d9da05cf9d9596
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1f32dc5cab](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1f32dc5cab)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3290851129/jobs/5424244820)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #14422:
URL: https://github.com/apache/arrow/pull/14422#discussion_r997539117
##########
java/pom.xml:
##########
@@ -1058,7 +1058,7 @@
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_LIBDIR=lib
-DCMAKE_INSTALL_PREFIX=${arrow.dataset.jni.dist.dir}
- -DCMAKE_PREFIX_PATH=${project.basedir}/../java-dist
+ -DCMAKE_PREFIX_PATH=${project.basedir}/../${os.detected.arch}/java-dist
Review Comment:
Hi Rok, I could suggest that is needed to add `${os.detected.arch}` before all places working with folder `java-dist`
The you could test your changes locally with this maven command please: `mvn generate-resources -Pgenerate-libs-jni-macos-linux -N` inside of `arrow/java` folder ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1283087826
Revision: 41bd8c985f080275a84dc195e6560b458eac9805
Submitted crossbow builds: [ursacomputing/crossbow @ actions-af76c4e2da](https://github.com/ursacomputing/crossbow/branches/all?query=actions-af76c4e2da)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/tree/actions-af76c4e2da-github-java-jars)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285423461
Revision: 768376e3751b0595ef4693fb8b7c989ca3f6622a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c3a2d2a18a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c3a2d2a18a)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3289440331/jobs/5420971685)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285469643
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285582823
Revision: c0ad6581543725c4e20a210009d9da05cf9d9596
Submitted crossbow builds: [ursacomputing/crossbow @ actions-bb4f5505c8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bb4f5505c8)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3290161879/jobs/5422631575)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1287291362
Closing in favor of #14472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1285387749
Revision: ba6d3c7444ccb92a9b6cd878d03c9c31f9454264
Submitted crossbow builds: [ursacomputing/crossbow @ actions-39d6385ff2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-39d6385ff2)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3289293897/jobs/5420651408)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a diff in pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on code in PR #14422:
URL: https://github.com/apache/arrow/pull/14422#discussion_r995892127
##########
java/pom.xml:
##########
@@ -1058,7 +1058,7 @@
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_LIBDIR=lib
-DCMAKE_INSTALL_PREFIX=${arrow.dataset.jni.dist.dir}
- -DCMAKE_PREFIX_PATH=${project.basedir}/../java-dist
+ -DCMAKE_PREFIX_PATH=${project.basedir}/../${os.detected.arch}/java-dist
Review Comment:
@davisusanibar is this enough to pull the correct modules or do we need to adjust more paths?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
rok commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1283847087
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on PR #14422:
URL: https://github.com/apache/arrow/pull/14422#issuecomment-1281539579
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org