You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/06/01 06:18:48 UTC
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated June 1, 2015, 4:18 a.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Changes
-------
Rebase from current master
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review87743
-----------------------------------------------------------
Ship it!
Minor style issue, I'll clean it up for you and get this committed.
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment140153>
Whitespace here to match our other code:
```
$ grep -R "operator ()" src
src/master/allocator/sorter/drf/sorter.cpp:bool DRFComparator::operator () (const Client& client1, const Client& client2)
src/master/allocator/sorter/drf/sorter.hpp: virtual bool operator () (const Client& client1, const Client& client2);
src/master/registrar.hpp: Try<bool> operator () (
```
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment140154>
Ditto here.
- Ben Mahler
On June 1, 2015, 6:55 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 6:55 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review85960
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33792, 34068]
All tests passed.
- Mesos ReviewBot
On June 1, 2015, 6:55 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 6:55 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated June 1, 2015, 6:55 a.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated June 1, 2015, 6:08 a.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang