[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3779: New data version to support no-chop changes, disable upgrade

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3779:
URL: https://github.com/apache/accumulo/pull/3779#discussion_r1337676816


##########
server/base/src/main/java/org/apache/accumulo/server/AccumuloDataVersion.java:
##########
@@ -71,7 +77,11 @@ public static int get() {
     return CURRENT_VERSION;
   }
 
-  public static final Set<Integer> CAN_RUN = Set.of(ROOT_TABLET_META_CHANGES, CURRENT_VERSION);
+  // TODO - this is currently set to disable upgrades until metadata file json conversion
+  // implemented
+  // public static final Set<Integer> CAN_RUN = Set.of(REMOVE_DEPRECATIONS_FOR_VERSION_3,
+  // CURRENT_VERSION);

Review Comment:
   ```suggestion
     // TODO - this disables upgrades until https://github.com/apache/accumulo/issues/3768 is done
     // public static final Set<Integer> CAN_RUN = Set.of(REMOVE_DEPRECATIONS_FOR_VERSION_3,
     // CURRENT_VERSION);
   ```



##########
server/base/src/test/java/org/apache/accumulo/server/ServerContextTest.java:
##########
@@ -135,7 +135,9 @@ public void testCanRun() {
     // ensure this fails with older versions; the oldest supported version is hard-coded here
     // to ensure we don't unintentionally break upgrade support; changing this should be a conscious
     // decision and this check will ensure we don't overlook it
-    final int oldestSupported = AccumuloDataVersion.ROOT_TABLET_META_CHANGES;
+
+    // TODO basically disable check until upgrade to 3.1 is supported.
+    final int oldestSupported = AccumuloDataVersion.METADATA_FILE_JSON_ENCODING;

Review Comment:
   Instead of doing this, you should use `@Disabled`
   
   ```suggestion
       final int oldestSupported = AccumuloDataVersion.ROOT_TABLET_META_CHANGES;
   ```
   
   On the method, add:
   
   
   ```java
   @Disabled("must fix https://github.com/apache/accumulo/issues/3768 to re-enable")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org