You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by NormW <no...@gknw.net> on 2011/07/03 01:22:47 UTC
httpd-trunk r1133163 modules\dav\fs\dbm.c
G/M,
Now get this when compiling:
> CC mod_dav_fs.c
> CC dbm.c
> ### mwccnlm Compiler:
> # File: dbm.c
> # --------------
> # 45: APLOG_USE_MODULE(dav_fs);
> # Error: ^
> # identifier expected
seems like the 'dav_fs' symbol isn't visible here?
Norm
Re: httpd-trunk r1133163 modules\dav\fs\dbm.c
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Sunday 03 July 2011, NormW wrote:
> dbm.c (and mod_dav_fs) build without issue for NetWare
Thanks for testing. Patch is commited to trunk
Re: httpd-trunk r1133163 modules\dav\fs\dbm.c
Posted by NormW <no...@gknw.net>.
Hi,
OAtched http_log.h as indicated and and dbm.c (and mod_dav_fs) build
without issue for NetWare. Two symbols to chose from and I naturally
picked the wrong one.
Cheers,
Norm
On 3/07/2011 5:17 PM, Stefan Fritsch wrote:
> On Sunday 03 July 2011, NormW wrote:
>> G/M,
>>
>> Now get this when compiling:
>>> CC mod_dav_fs.c
>>> CC dbm.c
>>> ### mwccnlm Compiler:
>>> # File: dbm.c
>>> # --------------
>>> # 45: APLOG_USE_MODULE(dav_fs);
>>> # Error: ^
>>> # identifier expected
>>
>> seems like the 'dav_fs' symbol isn't visible here?
>
> No, APLOG_USE_MODULE declares the symbol. But it seems there is an
> include at the wrong position, inside a #ifdef HAVE_SYSLOG. Please try
> this patch:
>
> --- include/http_log.h
> +++ include/http_log.h
> @@ -31,12 +31,11 @@ extern "C" {
> #endif
>
> #include "apr_thread_proc.h"
> +#include "http_config.h"
>
> #ifdef HAVE_SYSLOG
> #include<syslog.h>
>
> -#include "http_config.h"
> -
> #ifndef LOG_PRIMASK
> #define LOG_PRIMASK 7
> #endif
>
Re: httpd-trunk r1133163 modules\dav\fs\dbm.c
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Sunday 03 July 2011, NormW wrote:
> G/M,
>
> Now get this when compiling:
> > CC mod_dav_fs.c
> > CC dbm.c
> > ### mwccnlm Compiler:
> > # File: dbm.c
> > # --------------
> > # 45: APLOG_USE_MODULE(dav_fs);
> > # Error: ^
> > # identifier expected
>
> seems like the 'dav_fs' symbol isn't visible here?
No, APLOG_USE_MODULE declares the symbol. But it seems there is an
include at the wrong position, inside a #ifdef HAVE_SYSLOG. Please try
this patch:
--- include/http_log.h
+++ include/http_log.h
@@ -31,12 +31,11 @@ extern "C" {
#endif
#include "apr_thread_proc.h"
+#include "http_config.h"
#ifdef HAVE_SYSLOG
#include <syslog.h>
-#include "http_config.h"
-
#ifndef LOG_PRIMASK
#define LOG_PRIMASK 7
#endif