[GitHub] [rocketmq] areyouok edited a comment on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution

[GitBox <gi...@apache.org>]

areyouok edited a comment on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992420954


   > @haozhijie9527 @areyouok Please help to check again
   
   The synchronized block in RequestFutureHolder is not safe enough. Concurrent problem still exists.
   
   I sugguest move DefaultMQProducerImpl.startScheduledTask() and 
   
   ```
                   if (RequestFutureHolder.getInstance().getProducerNum().decrementAndGet() == 0) {
                       RequestFutureHolder.getInstance().getScheduledExecutorService().shutdown();
                   }
   ```
   
   to RequestFutureHolder.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org