You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/09/05 12:39:15 UTC
Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for
alert definitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/
-----------------------------------------------------------
(Updated Sept. 5, 2017, 2:39 p.m.)
Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor Magyari, Sebastian Toader, and Sid Wagle.
Changes
-------
minor tweak
Bugs: AMBARI-21803
https://issues.apache.org/jira/browse/AMBARI-21803
Repository: ambari
Description
-------
* Added endpoint
* Created data structure to match expected JSON format
* Extracted some common logic to parent classes
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
ambari-agent/src/main/python/ambari_agent/Constants.py e36eda577d0195055ebe89e3eeac5c63aa4a460b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java 0f0a4919ba7e1343c31c8397d5309542c2463287
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java 7035f38cfbb7a75bd4cb5721a542ef832a805c99
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java 635611bf6d325deb33cde671556647b9c264a716
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java 792f10ef33363fd57579792f51901681ad83aa0b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java db093f85a7f304e895bad098a3ca5a62d7a3859d
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java b7e680627f3fd42e87b7152f9ab9de29f63a44fa
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 0da5d831d546da98e2284b048b914f972cacfc05
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java 3ee5ad6d00b4c4374cba48e80d1cb410500ee586
ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java e820401d460bc672596a4ede60abcd39646be49e
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java cbe6e3703960ce0af9563f41b63d2a71427b4267
ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java 66ab38ea39bea2c100a2245ad422a4c6a037d7ed
ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java 239b5b8184a02a057c2dc9d4a53c671dc06d9806
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java 1b5b90b562babe4cea18a1bd93104d72922d31fa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 25bc8136510574cc54fa2f3365c755e6a9426547
Diff: https://reviews.apache.org/r/61886/diff/2/
Changes: https://reviews.apache.org/r/61886/diff/1-2/
Testing
-------
Manually tested server/agent restarts, alert definition changes.
Thanks,
Attila Doroszlai
Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for
alert definitions
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/#review184545
-----------------------------------------------------------
Atilla, as far as I saw from our test cluster, the java code you have now sends port property as "defaultPort" and "port" instead of "default_port".
Is that expected to happen? Should I do the change in python code to reflect this?
- Andrew Onischuk
On Sept. 5, 2017, 12:39 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61886/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2017, 12:39 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor Magyari, Sebastian Toader, and Sid Wagle.
>
>
> Bugs: AMBARI-21803
> https://issues.apache.org/jira/browse/AMBARI-21803
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added endpoint
> * Created data structure to match expected JSON format
> * Extracted some common logic to parent classes
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
> ambari-agent/src/main/python/ambari_agent/Constants.py e36eda577d0195055ebe89e3eeac5c63aa4a460b
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java 0f0a4919ba7e1343c31c8397d5309542c2463287
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java 7035f38cfbb7a75bd4cb5721a542ef832a805c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java 635611bf6d325deb33cde671556647b9c264a716
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java 792f10ef33363fd57579792f51901681ad83aa0b
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java db093f85a7f304e895bad098a3ca5a62d7a3859d
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java b7e680627f3fd42e87b7152f9ab9de29f63a44fa
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 0da5d831d546da98e2284b048b914f972cacfc05
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java 3ee5ad6d00b4c4374cba48e80d1cb410500ee586
> ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java e820401d460bc672596a4ede60abcd39646be49e
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java cbe6e3703960ce0af9563f41b63d2a71427b4267
> ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java 66ab38ea39bea2c100a2245ad422a4c6a037d7ed
> ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java 239b5b8184a02a057c2dc9d4a53c671dc06d9806
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java 1b5b90b562babe4cea18a1bd93104d72922d31fa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 25bc8136510574cc54fa2f3365c755e6a9426547
>
>
> Diff: https://reviews.apache.org/r/61886/diff/2/
>
>
> Testing
> -------
>
> Manually tested server/agent restarts, alert definition changes.
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for
alert definitions
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/
-----------------------------------------------------------
(Updated Sept. 29, 2017, 3:39 p.m.)
Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor Magyari, Sebastian Toader, and Sid Wagle.
Changes
-------
rebased after merge
Bugs: AMBARI-21803
https://issues.apache.org/jira/browse/AMBARI-21803
Repository: ambari
Description
-------
* Added endpoint
* Created data structure to match expected JSON format
* Added @JsonProperty for all attributes (to explicitly specify names)
* Added @JsonInclude to avoid null values
* Extracted some common logic to parent classes
* Clarified `HostNotRegisteredException`
* Simplified some `equals()`/`hashCode()` methods
* Simplified map operations in `AgentSessionManager`
* Handle alert report with reduced content (no service/component names)
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
ambari-agent/src/main/python/ambari_agent/Constants.py 4c0b01bdd664e23581c5c6a494bd20a2c8314058
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py 494d0f3e9a21608d9bd3e5922309a7c013fd333e
ambari-server/src/main/java/org/apache/ambari/server/HostNotRegisteredException.java 9e7b3a7efbfe09bdfa8d1dc0203d9370da881cb1
ambari-server/src/main/java/org/apache/ambari/server/agent/AgentSessionManager.java 1f64fc1d2800fa2b1a1c6d82a2ca855f9e30bbca
ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java a4324ee9a23f86e1d99a441a2c49383282786aa2
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java 0f0a4919ba7e1343c31c8397d5309542c2463287
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java 7035f38cfbb7a75bd4cb5721a542ef832a805c99
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java 635611bf6d325deb33cde671556647b9c264a716
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java 792f10ef33363fd57579792f51901681ad83aa0b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java 3d17ef2079049de49c5b64682a04a3578847d8d3
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java b7e680627f3fd42e87b7152f9ab9de29f63a44fa
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 0da5d831d546da98e2284b048b914f972cacfc05
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java 3ee5ad6d00b4c4374cba48e80d1cb410500ee586
ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/ApiStompConfig.java 170fa1704cd86c39db629aa74c54114d56b766dd
ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java e820401d460bc672596a4ede60abcd39646be49e
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java cbe6e3703960ce0af9563f41b63d2a71427b4267
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariUpdateEvent.java 90aa704ba1530cd77a13b77db5183f398a4f659e
ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java 66ab38ea39bea2c100a2245ad422a4c6a037d7ed
ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java 239b5b8184a02a057c2dc9d4a53c671dc06d9806
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java 0ba4ac2ee5d42d5bae3ca1ff6da6e35bb8d06fc8
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java 8acc401c8367909944c8d38deda2cd8b5b6fe2a9
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java 1b5b90b562babe4cea18a1bd93104d72922d31fa
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 257e2fffe325eabfe4773445b0d3bb36d2c59729
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/requests/StateUpdateListener.java 27af7178c497f8ac171b4c788a966cfcb6de9278
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 9473cfcd0c7f23ca5b5e63be58bff28cae0a09b1
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java 64c983f8f8600ee6388769dfc4f1a158c6edff60
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java 665430dacf342aa4343c3a6e4e0a8ab219640d88
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 8dd78cfcdd35cc1c131f396a37177460f6785732
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 7b0107be9710f9ca2fa0c6e3e246432cabb5a7d1
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java d586f8181be241855e3119924dc8a348724a9497
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 11eee05629899e4c1885c568f37d7b091fcec6d6
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java 8ae8d1fb12482c998af3826b53c10f673bd1816f
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java 927d8934eae34c7415097234029248b31a6cd908
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java 7b893824719471b5d356fa1a0be52ebbead36a90
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java dc03e2fcaf2aa9bd75563833b73bb5b11ad2a242
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java a5ed440bc8fc5d68afc0889e3c36fb09d4e9e654
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java c58867a67fee07a8061be37401aacc60cf49e06e
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java aa841d59492fed198644d80cb5cefd02307e1f0b
ambari-server/src/main/java/org/apache/ambari/server/state/alert/WebSource.java ef946047be538d4b010bd9de6e8e4a48501756ff
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 5141a4b62ba455499c30f69fd11c0da86cd03369
ambari-server/src/test/java/org/apache/ambari/server/agent/AgentSessionManagerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java 663934fd3ad63b7298a23fd5ab25ab26bc1b879e
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 50854ce9891ec3b9d31457866965abb8c367f5fd
Diff: https://reviews.apache.org/r/61886/diff/6/
Changes: https://reviews.apache.org/r/61886/diff/5-6/
Testing
-------
* Manually tested server/agent restarts, alert definition changes
* New unit test for `AgentSessionManager`
Thanks,
Attila Doroszlai
Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for
alert definitions
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/#review186309
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Sept. 25, 2017, 2:19 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61886/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2017, 2:19 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor Magyari, Sebastian Toader, and Sid Wagle.
>
>
> Bugs: AMBARI-21803
> https://issues.apache.org/jira/browse/AMBARI-21803
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added endpoint
> * Created data structure to match expected JSON format
> * Added @JsonProperty for all attributes (to explicitly specify names)
> * Added @JsonInclude to avoid null values
> * Extracted some common logic to parent classes
> * Clarified `HostNotRegisteredException`
> * Simplified some `equals()`/`hashCode()` methods
> * Simplified map operations in `AgentSessionManager`
> * Handle alert report with reduced content (no service/component names)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
> ambari-agent/src/main/python/ambari_agent/Constants.py 6a258d26a3a5d03ab76a70208321f13936a99dc7
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py b6e1aaf5c721bcd464458d5a83448b2f96c39d62
> ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py 91ae5de02f2788745ee87458c92c0845e6a258f4
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 3c571ab89e5114c8eb1cd2dc7213ff53561c678e
> ambari-server/src/main/java/org/apache/ambari/server/HostNotRegisteredException.java 9e7b3a7efbfe09bdfa8d1dc0203d9370da881cb1
> ambari-server/src/main/java/org/apache/ambari/server/agent/AgentSessionManager.java 1f64fc1d2800fa2b1a1c6d82a2ca855f9e30bbca
> ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java 07029c76e0d6e4ee2df40f6c64746506f2309826
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java 0f0a4919ba7e1343c31c8397d5309542c2463287
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java 7035f38cfbb7a75bd4cb5721a542ef832a805c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java 635611bf6d325deb33cde671556647b9c264a716
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java 792f10ef33363fd57579792f51901681ad83aa0b
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java db093f85a7f304e895bad098a3ca5a62d7a3859d
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java b7e680627f3fd42e87b7152f9ab9de29f63a44fa
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 0da5d831d546da98e2284b048b914f972cacfc05
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java 3ee5ad6d00b4c4374cba48e80d1cb410500ee586
> ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/ApiStompConfig.java 170fa1704cd86c39db629aa74c54114d56b766dd
> ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java e820401d460bc672596a4ede60abcd39646be49e
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java cbe6e3703960ce0af9563f41b63d2a71427b4267
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariUpdateEvent.java 90aa704ba1530cd77a13b77db5183f398a4f659e
> ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java 66ab38ea39bea2c100a2245ad422a4c6a037d7ed
> ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java 239b5b8184a02a057c2dc9d4a53c671dc06d9806
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java 3ad149241fb50d3bbbc55fb141cf6bbbe7c6c289
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java 6f3fa95cd1fa8055b02c09eff538db7453301110
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java 1b5b90b562babe4cea18a1bd93104d72922d31fa
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 3607df4f0c9c96ee0bed741a12195a4d428e6b90
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/requests/StateUpdateListener.java 27af7178c497f8ac171b4c788a966cfcb6de9278
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 25bc8136510574cc54fa2f3365c755e6a9426547
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java 46ddd355b67e75da9cf98b365d830bd8cd7e20bd
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java e197cd0050c97fa655ceefa21a5763227c1890ec
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 76905085aab60771474fac4979ccbe560245aa9b
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c2ef5e7859464c22ce64a90a6c771eeff803ba38
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java 21cf81c8cd0abd91940b73e60c40db4a68496637
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 25734cd496a3d3fa2f7f89716c1080ca2798c069
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java 92c49203a44bfd5d829f7f1835e97116029f1ee6
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java 57bba06d723470e6f8c26a4961c7e37db05ebdfa
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java e972c621d7361538105cb54734cb2c0b582daef8
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java 4aaefab33713c7641cab3775c615e87c1d96d82c
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java d1b70701ae26c3117f7b9fb8ece2676c0f3d45cb
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java d5a69abcbb36bebd2776e61f5aa3ebcc3724df63
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java 76054a9c8cb3e0f79ce50c2b8be2699f0dd6741f
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/WebSource.java a3c0ada908716e59db8516a8bdef75b7c2814806
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 446ae8c4850eb60dcc0d18f93a4b3ddbd4882a35
> ambari-server/src/test/java/org/apache/ambari/server/agent/AgentSessionManagerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java c0d445a32f6a8153ea19ffc4cb25874637929fb5
>
>
> Diff: https://reviews.apache.org/r/61886/diff/5/
>
>
> Testing
> -------
>
> * Manually tested server/agent restarts, alert definition changes
> * New unit test for `AgentSessionManager`
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for
alert definitions
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/
-----------------------------------------------------------
(Updated Sept. 25, 2017, 4:19 p.m.)
Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor Magyari, Sebastian Toader, and Sid Wagle.
Bugs: AMBARI-21803
https://issues.apache.org/jira/browse/AMBARI-21803
Repository: ambari
Description (updated)
-------
* Added endpoint
* Created data structure to match expected JSON format
* Added @JsonProperty for all attributes (to explicitly specify names)
* Added @JsonInclude to avoid null values
* Extracted some common logic to parent classes
* Clarified `HostNotRegisteredException`
* Simplified some `equals()`/`hashCode()` methods
* Simplified map operations in `AgentSessionManager`
* Handle alert report with reduced content (no service/component names)
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
ambari-agent/src/main/python/ambari_agent/Constants.py 6a258d26a3a5d03ab76a70208321f13936a99dc7
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py b6e1aaf5c721bcd464458d5a83448b2f96c39d62
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py 91ae5de02f2788745ee87458c92c0845e6a258f4
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 3c571ab89e5114c8eb1cd2dc7213ff53561c678e
ambari-server/src/main/java/org/apache/ambari/server/HostNotRegisteredException.java 9e7b3a7efbfe09bdfa8d1dc0203d9370da881cb1
ambari-server/src/main/java/org/apache/ambari/server/agent/AgentSessionManager.java 1f64fc1d2800fa2b1a1c6d82a2ca855f9e30bbca
ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java 07029c76e0d6e4ee2df40f6c64746506f2309826
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java 0f0a4919ba7e1343c31c8397d5309542c2463287
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java 7035f38cfbb7a75bd4cb5721a542ef832a805c99
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java 635611bf6d325deb33cde671556647b9c264a716
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java 792f10ef33363fd57579792f51901681ad83aa0b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java db093f85a7f304e895bad098a3ca5a62d7a3859d
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java b7e680627f3fd42e87b7152f9ab9de29f63a44fa
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 0da5d831d546da98e2284b048b914f972cacfc05
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java 3ee5ad6d00b4c4374cba48e80d1cb410500ee586
ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/ApiStompConfig.java 170fa1704cd86c39db629aa74c54114d56b766dd
ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java e820401d460bc672596a4ede60abcd39646be49e
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java cbe6e3703960ce0af9563f41b63d2a71427b4267
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariUpdateEvent.java 90aa704ba1530cd77a13b77db5183f398a4f659e
ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java 66ab38ea39bea2c100a2245ad422a4c6a037d7ed
ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java 239b5b8184a02a057c2dc9d4a53c671dc06d9806
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java 3ad149241fb50d3bbbc55fb141cf6bbbe7c6c289
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java 6f3fa95cd1fa8055b02c09eff538db7453301110
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java 1b5b90b562babe4cea18a1bd93104d72922d31fa
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 3607df4f0c9c96ee0bed741a12195a4d428e6b90
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/requests/StateUpdateListener.java 27af7178c497f8ac171b4c788a966cfcb6de9278
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 25bc8136510574cc54fa2f3365c755e6a9426547
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java 46ddd355b67e75da9cf98b365d830bd8cd7e20bd
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java e197cd0050c97fa655ceefa21a5763227c1890ec
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 76905085aab60771474fac4979ccbe560245aa9b
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c2ef5e7859464c22ce64a90a6c771eeff803ba38
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java 21cf81c8cd0abd91940b73e60c40db4a68496637
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 25734cd496a3d3fa2f7f89716c1080ca2798c069
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java 92c49203a44bfd5d829f7f1835e97116029f1ee6
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java 57bba06d723470e6f8c26a4961c7e37db05ebdfa
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java e972c621d7361538105cb54734cb2c0b582daef8
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java 4aaefab33713c7641cab3775c615e87c1d96d82c
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java d1b70701ae26c3117f7b9fb8ece2676c0f3d45cb
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java d5a69abcbb36bebd2776e61f5aa3ebcc3724df63
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java 76054a9c8cb3e0f79ce50c2b8be2699f0dd6741f
ambari-server/src/main/java/org/apache/ambari/server/state/alert/WebSource.java a3c0ada908716e59db8516a8bdef75b7c2814806
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 446ae8c4850eb60dcc0d18f93a4b3ddbd4882a35
ambari-server/src/test/java/org/apache/ambari/server/agent/AgentSessionManagerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java c0d445a32f6a8153ea19ffc4cb25874637929fb5
Diff: https://reviews.apache.org/r/61886/diff/5/
Changes: https://reviews.apache.org/r/61886/diff/4-5/
Testing (updated)
-------
* Manually tested server/agent restarts, alert definition changes
* New unit test for `AgentSessionManager`
Thanks,
Attila Doroszlai
Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for
alert definitions
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/
-----------------------------------------------------------
(Updated Sept. 7, 2017, 1:59 p.m.)
Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor Magyari, Sebastian Toader, and Sid Wagle.
Changes
-------
* added @JsonProperty for all attributes (to explicitly specify names)
* added @JsonInclude to avoid `null` values
* simplified some equals()/hashCode() methods
Bugs: AMBARI-21803
https://issues.apache.org/jira/browse/AMBARI-21803
Repository: ambari
Description
-------
* Added endpoint
* Created data structure to match expected JSON format
* Extracted some common logic to parent classes
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
ambari-agent/src/main/python/ambari_agent/Constants.py e36eda577d0195055ebe89e3eeac5c63aa4a460b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java 0f0a4919ba7e1343c31c8397d5309542c2463287
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java 7035f38cfbb7a75bd4cb5721a542ef832a805c99
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java 635611bf6d325deb33cde671556647b9c264a716
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java 792f10ef33363fd57579792f51901681ad83aa0b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java db093f85a7f304e895bad098a3ca5a62d7a3859d
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java b7e680627f3fd42e87b7152f9ab9de29f63a44fa
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 0da5d831d546da98e2284b048b914f972cacfc05
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java 3ee5ad6d00b4c4374cba48e80d1cb410500ee586
ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java e820401d460bc672596a4ede60abcd39646be49e
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java cbe6e3703960ce0af9563f41b63d2a71427b4267
ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java 66ab38ea39bea2c100a2245ad422a4c6a037d7ed
ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java 239b5b8184a02a057c2dc9d4a53c671dc06d9806
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java 1b5b90b562babe4cea18a1bd93104d72922d31fa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 25bc8136510574cc54fa2f3365c755e6a9426547
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java 46ddd355b67e75da9cf98b365d830bd8cd7e20bd
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java e197cd0050c97fa655ceefa21a5763227c1890ec
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c2ef5e7859464c22ce64a90a6c771eeff803ba38
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java 21cf81c8cd0abd91940b73e60c40db4a68496637
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 25734cd496a3d3fa2f7f89716c1080ca2798c069
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java 92c49203a44bfd5d829f7f1835e97116029f1ee6
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java 57bba06d723470e6f8c26a4961c7e37db05ebdfa
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java e972c621d7361538105cb54734cb2c0b582daef8
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java 4aaefab33713c7641cab3775c615e87c1d96d82c
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java d1b70701ae26c3117f7b9fb8ece2676c0f3d45cb
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java d5a69abcbb36bebd2776e61f5aa3ebcc3724df63
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java 76054a9c8cb3e0f79ce50c2b8be2699f0dd6741f
ambari-server/src/main/java/org/apache/ambari/server/state/alert/WebSource.java a3c0ada908716e59db8516a8bdef75b7c2814806
Diff: https://reviews.apache.org/r/61886/diff/4/
Changes: https://reviews.apache.org/r/61886/diff/3-4/
Testing
-------
Manually tested server/agent restarts, alert definition changes.
Thanks,
Attila Doroszlai
Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for
alert definitions
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/#review184799
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Sept. 5, 2017, 8:20 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61886/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2017, 8:20 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor Magyari, Sebastian Toader, and Sid Wagle.
>
>
> Bugs: AMBARI-21803
> https://issues.apache.org/jira/browse/AMBARI-21803
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added endpoint
> * Created data structure to match expected JSON format
> * Extracted some common logic to parent classes
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
> ambari-agent/src/main/python/ambari_agent/Constants.py e36eda577d0195055ebe89e3eeac5c63aa4a460b
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java 0f0a4919ba7e1343c31c8397d5309542c2463287
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java 7035f38cfbb7a75bd4cb5721a542ef832a805c99
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java 635611bf6d325deb33cde671556647b9c264a716
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java 792f10ef33363fd57579792f51901681ad83aa0b
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java db093f85a7f304e895bad098a3ca5a62d7a3859d
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java b7e680627f3fd42e87b7152f9ab9de29f63a44fa
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 0da5d831d546da98e2284b048b914f972cacfc05
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java 3ee5ad6d00b4c4374cba48e80d1cb410500ee586
> ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java e820401d460bc672596a4ede60abcd39646be49e
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java cbe6e3703960ce0af9563f41b63d2a71427b4267
> ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java 66ab38ea39bea2c100a2245ad422a4c6a037d7ed
> ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java 239b5b8184a02a057c2dc9d4a53c671dc06d9806
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java 1b5b90b562babe4cea18a1bd93104d72922d31fa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 25bc8136510574cc54fa2f3365c755e6a9426547
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java 46ddd355b67e75da9cf98b365d830bd8cd7e20bd
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java e197cd0050c97fa655ceefa21a5763227c1890ec
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c2ef5e7859464c22ce64a90a6c771eeff803ba38
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java 21cf81c8cd0abd91940b73e60c40db4a68496637
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 25734cd496a3d3fa2f7f89716c1080ca2798c069
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java 92c49203a44bfd5d829f7f1835e97116029f1ee6
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java 57bba06d723470e6f8c26a4961c7e37db05ebdfa
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java e972c621d7361538105cb54734cb2c0b582daef8
>
>
> Diff: https://reviews.apache.org/r/61886/diff/3/
>
>
> Testing
> -------
>
> Manually tested server/agent restarts, alert definition changes.
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for
alert definitions
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/
-----------------------------------------------------------
(Updated Sept. 5, 2017, 8:20 p.m.)
Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor Magyari, Sebastian Toader, and Sid Wagle.
Changes
-------
added @JsonProperty where necessary
Bugs: AMBARI-21803
https://issues.apache.org/jira/browse/AMBARI-21803
Repository: ambari
Description
-------
* Added endpoint
* Created data structure to match expected JSON format
* Extracted some common logic to parent classes
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
ambari-agent/src/main/python/ambari_agent/Constants.py e36eda577d0195055ebe89e3eeac5c63aa4a460b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java 0f0a4919ba7e1343c31c8397d5309542c2463287
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java 0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java 7035f38cfbb7a75bd4cb5721a542ef832a805c99
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java 635611bf6d325deb33cde671556647b9c264a716
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java 792f10ef33363fd57579792f51901681ad83aa0b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java db093f85a7f304e895bad098a3ca5a62d7a3859d
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java b7e680627f3fd42e87b7152f9ab9de29f63a44fa
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java 0da5d831d546da98e2284b048b914f972cacfc05
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java 3ee5ad6d00b4c4374cba48e80d1cb410500ee586
ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java 640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java e820401d460bc672596a4ede60abcd39646be49e
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java cbe6e3703960ce0af9563f41b63d2a71427b4267
ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java 66ab38ea39bea2c100a2245ad422a4c6a037d7ed
ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java 239b5b8184a02a057c2dc9d4a53c671dc06d9806
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java 1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java 1b5b90b562babe4cea18a1bd93104d72922d31fa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 25bc8136510574cc54fa2f3365c755e6a9426547
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java 46ddd355b67e75da9cf98b365d830bd8cd7e20bd
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java e197cd0050c97fa655ceefa21a5763227c1890ec
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c2ef5e7859464c22ce64a90a6c771eeff803ba38
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java 21cf81c8cd0abd91940b73e60c40db4a68496637
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 25734cd496a3d3fa2f7f89716c1080ca2798c069
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java 92c49203a44bfd5d829f7f1835e97116029f1ee6
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java 57bba06d723470e6f8c26a4961c7e37db05ebdfa
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java e972c621d7361538105cb54734cb2c0b582daef8
Diff: https://reviews.apache.org/r/61886/diff/3/
Changes: https://reviews.apache.org/r/61886/diff/2-3/
Testing
-------
Manually tested server/agent restarts, alert definition changes.
Thanks,
Attila Doroszlai