You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/01/04 00:37:16 UTC

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #670: PHOENIX-5630: MAX_MUTATION_SIZE_EXCEEDED and MAX_MUTATION_SIZE_BYTES_EXCEEDED SQLExceptions should print existing size

ChinmaySKulkarni commented on a change in pull request #670: PHOENIX-5630: MAX_MUTATION_SIZE_EXCEEDED and MAX_MUTATION_SIZE_BYTES_EXCEEDED SQLExceptions should print existing size
URL: https://github.com/apache/phoenix/pull/670#discussion_r363002514
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionInfo.java
 ##########
 @@ -47,6 +51,10 @@
     private final String familyName;
     private final String columnName;
     private final String functionName;
+    private final long maxMutationSize;
+    private final int mutationSize;
 
 Review comment:
   @nsgupta1 I think it's fine to keep both to `int` too. But, then for consistency, also better to make the data type change in other relevant places too as @mihir6692 mentioned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services