You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org> on 2016/09/20 22:29:14 UTC
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Ninad Shringarpure has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4483
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
[doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
Missing space before the hyperlink was causing this issue.
Please check the resultant html here:
https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html
Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
---
M docs/kudu_impala_integration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/1
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
Patch Set 2: Code-Review+1
CI is having a rough time with recent build changes. This patch should be fine, since it's just docs.
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4483
to look at the new patch set (#3).
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
[doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
Missing space before the hyperlink was causing this issue.
Hyperlinked "Impala documentation" text to appropriate impala link.
Complete text being:
See the Impala documentation for more information about internal and external tables.
Please check the resultant html here:
https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html
Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
---
M docs/kudu_impala_integration.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/3
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4483/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
Line 349: See link: http://www.cloudera.com/content/cloudera/en/documentation/core/latest/topics/impala_tables.html
I think it would be preferable to give this link some actual text. like "See the Impala documentation for more information about internal and external tables." (with a link from 'Impala documentation' to the appropriate page).
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
Patch Set 2: -Code-Review Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4483
to look at the new patch set (#5).
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
[doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
Missing space before the hyperlink was causing this issue.
Hyperlinked "Impala documentation" text to appropriate impala link.
Complete text being:
See the Impala documentation for more information about internal and external tables.
Please check the resultant html here:
https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html
Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
---
M docs/kudu_impala_integration.adoc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/5
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4483/4/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
PS4, Line 349:
Hey Ninad, could you remove the trailing whitespace from this line and the one below?
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4483/2/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
Line 349: See the http://www.cloudera.com/content/cloudera/en/documentation/core/latest/topics/impala_tables.html[Impala documentation] for more information about internal and external tables.
could you preserve the line break?
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
[doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
Missing space before the hyperlink was causing this issue.
Hyperlinked "Impala documentation" text to appropriate impala link.
Complete text being:
See the Impala documentation for more information about internal and external tables.
Please check the resultant html here:
https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html
Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Reviewed-on: http://gerrit.cloudera.org:8080/4483
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Dan Burkert <da...@cloudera.com>
---
M docs/kudu_impala_integration.adoc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved; Verified
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4483
to look at the new patch set (#4).
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
[doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
Missing space before the hyperlink was causing this issue.
Hyperlinked "Impala documentation" text to appropriate impala link.
Complete text being:
See the Impala documentation for more information about internal and external tables.
Please check the resultant html here:
https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html
Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
---
M docs/kudu_impala_integration.adoc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/4
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4483
to look at the new patch set (#2).
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
[doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
Missing space before the hyperlink was causing this issue.
Hyperlinked "Impala documentation" text to appropriate impala link.
Complete text being:
See the Impala documentation for more information about internal and external tables.
Please check the resultant html here:
https://github.com/ninadshr/sample_repo/blob/master/kudu_impala_integration.html
Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
---
M docs/kudu_impala_integration.adoc
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4483/2
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [doc] KUDU-1630 impala tables.html link is showing as text and not actual link
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [doc] KUDU-1630 impala_tables.html link is showing as text and not actual link
......................................................................
Patch Set 5: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25c1251b312586b38a558eb3365f60f7ff3a7ba0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No