You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by dcaba <gi...@git.apache.org> on 2016/09/02 13:55:21 UTC
[GitHub] mesos pull request #165: mesoscon eu - hackatron exercise - CI using travis
GitHub user dcaba opened a pull request:
https://github.com/apache/mesos/pull/165
mesoscon eu - hackatron exercise - CI using travis
Hi,
reusing some of the work my colleague @danigiri did (mesos-build-helper) , i've adapted (and incorporated into the project) some scripts that, inside a container:
* resolves the compilation dependencies
* compiles
* and execute the tests
So TravisCI can execute this on branches and when triggering PRs against the project (currently is active, but does nothing out of adding red flags)...
Pending to do:
* actual error checking (probably we want to break the build if make test fails)
* remove some references to mesos_version (current scripts pick the latest checked out version)
That's it for now... let me know if it makes sense to complete the work (you probably are covering CI in a different way), but having this integrated in github may be good for contributors. Example of job that travis executed:
https://travis-ci.org/dcaba/mesos/builds/157089050
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcaba/mesos CI
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mesos/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit 1c448d3e2e9f982e73a486f8e29268218bf15559
Author: daniel-caballero <da...@schibsted.com>
Date: 2016-09-02T11:29:55Z
adding initial controller for the cibuild
commit 1a21165bc29dd02d8111c5b40e1090721aa5abf4
Author: daniel-caballero <da...@schibsted.com>
Date: 2016-09-02T12:50:20Z
bringing mesos-build-helper to the project, as we need to share the same project to build this original project without depending on external resources
commit 42b20b271dffa79aef5436899bca3d310fe07925
Author: daniel-caballero <da...@schibsted.com>
Date: 2016-09-02T13:00:44Z
compilation still broken, but first basic travis build
commit 53237deb2c417580e6222e73494335e7fbdda7ed
Author: daniel-caballero <da...@schibsted.com>
Date: 2016-09-02T13:03:54Z
compilation still broken, but first basic travis build
commit 8e6ed40bbac9a3ef50bfb844be29a364e4c78ab1
Author: daniel-caballero <da...@schibsted.com>
Date: 2016-09-02T13:06:40Z
travis with docker support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by kaysoky <gi...@git.apache.org>.
Github user kaysoky commented on the issue:
https://github.com/apache/mesos/pull/165
You can see [on the ASF Mesos CI](https://builds.apache.org/job/Mesos/buildTimeTrend) that successful builds typically takes 60-90 minutes. However, this is for `make distcheck`.
A `make check` should take ~40 minutes on a c3.2xlarge AWS instance (8 cores, 15 GB RAM, SSDs). This is probably beyond the free-tier of Travis.
If you're interested, here are two commits that show the history of Travis CI usage in Mesos. It was only enabled briefly between 0.22 and 0.23 :smile: :
* https://reviews.apache.org/r/28683/
* https://reviews.apache.org/r/34225/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by haosdent <gi...@git.apache.org>.
Github user haosdent commented on the issue:
https://github.com/apache/mesos/pull/165
Hi, @dcaba Since Mesos have used Apache CI to perform testings instead of travis ci, could refer to https://issues.apache.org/jira/browse/MESOS-5655 for the details. And thx @jfarrell, he just disabled the travis ci for Mesos. cc @vinodkone
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by haosdent <gi...@git.apache.org>.
Github user haosdent commented on the issue:
https://github.com/apache/mesos/pull/165
yah, actually apache jenkins have integrated with github. Could provide build status via this badge icons.
Build status: 
cmake,gcc,--verbose --enable-libevent --enable-ssl,GLOG_v=1 MESOS_VERBOSE=1,centos:7 &&(!ubuntu-us1)&&(!ubuntu-eu2)/badge/icon)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by dcaba <gi...@git.apache.org>.
Github user dcaba commented on the issue:
https://github.com/apache/mesos/pull/165
BTW,
I've just remembered a benefit of keeping this active (that will not affect too much that decision); Travis will run the compilation / ci task not only when you raise a PR against the mesos repo, but also in any branch or fork if the account has the integration active (not sure how Jenkins is configured in your case, but probably it does not have visibility of the forks potential contributors may be initating).
Best!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by janisz <gi...@git.apache.org>.
Github user janisz commented on the issue:
https://github.com/apache/mesos/pull/165
I agree with @dcaba if Travis is enabled then it should at least run style check (whole compile is good too).
> But I think we give up travis ci long time ago?
Why it's still enabled?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by dcaba <gi...@git.apache.org>.
Github user dcaba commented on the issue:
https://github.com/apache/mesos/pull/165
Great. Thanks for the update; this parallel CI job in travis (this PR was bringing) was not adding too much benefits (just the nice github <-> travis integration, that can show green ticks or red crosses in PRs submitted in this repo?), and it was only worth to fix the red crosses while the integration was still enabled. Closing PR then! Best!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by dcaba <gi...@git.apache.org>.
Github user dcaba commented on the issue:
https://github.com/apache/mesos/pull/165
Hi,
a bit surprised travis integration is still enabled (so all PRs have red crosses)... let me know if you want me to resolve the conflicts to integrate this (in addition to a basic travis job, there's also some other small amends I think are interesting). If not, I will just close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #165: mesoscon eu - hackatron exercise - CI using travis
Posted by janisz <gi...@git.apache.org>.
Github user janisz commented on a diff in the pull request:
https://github.com/apache/mesos/pull/165#discussion_r77374205
--- Diff: Dockerfile-ci ---
@@ -0,0 +1,23 @@
+# Copyright 2015 Daniel Giribet <dani - calidos.cat>
--- End diff --
Can we use same Dockerfile as we are using on Jenkins? Take a look at [support/docker_build.sh](https://github.com/apache/mesos/blob/42e8d6fb8b894c08b4b0c7cc40036fe630489bba/support/docker_build.sh)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #165: mesoscon eu - hackatron exercise - CI using travis
Posted by dcaba <gi...@git.apache.org>.
Github user dcaba commented on a diff in the pull request:
https://github.com/apache/mesos/pull/165#discussion_r78301199
--- Diff: Dockerfile-ci ---
@@ -0,0 +1,23 @@
+# Copyright 2015 Daniel Giribet <dani - calidos.cat>
--- End diff --
@janisz , yes! Not aware of its existence, and this duplication makes no sense... probably we should also add a link to http://mesos.apache.org/documentation/latest/submitting-a-patch/ in the project README, so all these supporting services are known for new contributors to apache projects. I will add a couple of commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by haosdent <gi...@git.apache.org>.
Github user haosdent commented on the issue:
https://github.com/apache/mesos/pull/165
Some experience to make it faster as well. https://reviews.apache.org/r/39257/diff/1#index_header (`- CXXFLAGS=-gsplit-dwarf`)
But I think we give up travis ci long time ago? Refer to https://issues.apache.org/jira/browse/MESOS-5655?focusedCommentId=15339918&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15339918
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by janisz <gi...@git.apache.org>.
Github user janisz commented on the issue:
https://github.com/apache/mesos/pull/165
+1 for merge. Can someone shepherd it or disable Travis and wire ASF Jenkins instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by dcaba <gi...@git.apache.org>.
Github user dcaba commented on the issue:
https://github.com/apache/mesos/pull/165
The build times out after 50 minutes (maximum job length the free version of travis allows)... I'm afraid we cannot afford executing all the tests in Travis (last one that initiates is tests/health_check_tests.cpp), so I can make configurable in support/docker_build.sh the task in the Makefile we want to execute (being the distcheck the default one, that Jenkins will continue using), or just dismiss Travis usage for this project... @janisz , any ideas/recommendations about how to proceed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #165: mesoscon eu - hackatron exercise - CI using travis
Posted by dcaba <gi...@git.apache.org>.
Github user dcaba commented on the issue:
https://github.com/apache/mesos/pull/165
Hi @kaysoky , @haosdent !
thanks so much for your comments. Yep, I see this is not new for the project, and I was missing a lot of context when I initiated this PR. So now we have two options, from my point of view:
- Dismiss this PR. This integration brings small or no value to the project (at a cost of a .travis.yml and keeping the integration active), as the free version of travis does not meet all the CI requirements you currently have covered with Jenkins.
- Accept the PR. This will fix the "red flag" we can see in all the PRs, and this job will potentially provide quicker feedback as we are only compiling in the end (while Jenkins will bring the results of all the test coverage later)
Please, make the decision bearing in mind what's more convenient for the project... No rancor at all if you close without merge ;) (it was an exercise requiring small efforts). But I'd appreciate the related Jira issue is closed (MESOS-5655) an you actually disable Travis to prevent these red crosses to add noise to all PRs.
Best,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #165: mesoscon eu - hackatron exercise - CI using travis
Posted by dcaba <gi...@git.apache.org>.
Github user dcaba closed the pull request at:
https://github.com/apache/mesos/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---