You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Zheng Wang (Jira)" <ji...@apache.org> on 2023/04/14 07:23:00 UTC

[jira] [Commented] (HBASE-27788) Skip family comparing when compare cells inner the store

    [ https://issues.apache.org/jira/browse/HBASE-27788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712226#comment-17712226 ] 

Zheng Wang commented on HBASE-27788:
------------------------------------

Perf test report(set compareCnt as 1 billion), copied from PR.

 
|compareMethod|leftFamLen|rightFamLen|comparator|cost(ms)|diff|
|compareKV|0|0|CellComparatorImpl|28850| |
|compareKV|0|0|InnerStoreCellComparator|27478|-5.00%|
|compareKV|0|4|CellComparatorImpl|19041| |
|compareKV|0|4|InnerStoreCellComparator|17391|-9.00%|
|compareKV|4|0|CellComparatorImpl|18988| |
|compareKV|4|0|InnerStoreCellComparator|17375|-8.00%|
|compareKV|4|4|CellComparatorImpl|33360| |
|compareKV|4|4|InnerStoreCellComparator|27083|-19.00%|
|compareBBKV|0|0|CellComparatorImpl|34014| |
|compareBBKV|0|0|InnerStoreCellComparator|31660|-7.00%|
|compareBBKV|0|4|CellComparatorImpl|20780| |
|compareBBKV|0|4|InnerStoreCellComparator|20847|0.00%|
|compareBBKV|4|0|CellComparatorImpl|23540| |
|compareBBKV|4|0|InnerStoreCellComparator|21751|-8.00%|
|compareBBKV|4|4|CellComparatorImpl|40192| |
|compareBBKV|4|4|InnerStoreCellComparator|31522|-22.00%|
|compareKVVsBBKV|0|0|CellComparatorImpl|30979| |
|compareKVVsBBKV|0|0|InnerStoreCellComparator|29827|-4.00%|
|compareKVVsBBKV|0|4|CellComparatorImpl|21918| |
|compareKVVsBBKV|0|4|InnerStoreCellComparator|19143|-13.00%|
|compareKVVsBBKV|4|0|CellComparatorImpl|22605| |
|compareKVVsBBKV|4|0|InnerStoreCellComparator|20952|-7.00%|
|compareKVVsBBKV|4|4|CellComparatorImpl|35561| |
|compareKVVsBBKV|4|4|InnerStoreCellComparator|29150|-18.00%|

> Skip family comparing when compare cells inner the store
> --------------------------------------------------------
>
>                 Key: HBASE-27788
>                 URL: https://issues.apache.org/jira/browse/HBASE-27788
>             Project: HBase
>          Issue Type: Improvement
>          Components: Performance
>            Reporter: Zheng Wang
>            Assignee: Zheng Wang
>            Priority: Major
>
> Currently we use CellComparatorImpl to compare cells, it compare row first, then family, then qulifier and so on.
> If the comparing inner the store, the families are always equal(unless the familyLength is zero for special purpose), so this step could be skipped for better performance.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)