You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/13 09:39:07 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4288: Support Group By for PostgreSQL for visitor
terrymanu opened a new pull request #4288: Support Group By for PostgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4288
For #4271.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4288:
Support Group By for PostgreSQL for visitor
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4288: Support Group By for PostgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4288#issuecomment-585651634
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4288?src=pr&el=h1) Report
> Merging [#4288](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4288?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/af5587bb6b53037842288bee84a8e5f1a0fa9f79?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4288?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4288 +/- ##
============================================
- Coverage 59.19% 59.16% -0.04%
Complexity 352 352
============================================
Files 1018 1018
Lines 17469 17478 +9
Branches 3120 3122 +2
============================================
Hits 10341 10341
- Misses 6473 6482 +9
Partials 655 655
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4288?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4288/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4288?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4288?src=pr&el=footer). Last update [af5587b...9ce9357](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4288:
Support Group By for PostgreSQL for visitor
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4288: Support Group By for PostgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4288#issuecomment-585650739
## Pull Request Test Coverage Report for [Build 1710](https://coveralls.io/builds/28707244)
* **0** of **9** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.02%**) to **62.982%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28707244/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L271) | 0 | 9 | 0.0%
<!-- | **Total:** | **0** | **9** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28707244/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28707244) |
| :-- | --: |
| Change from base [Build 9502](https://coveralls.io/builds/28706975): | -0.02% |
| Covered Lines: | 11008 |
| Relevant Lines: | 17478 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4288:
Support Group By for PostgreSQL for visitor
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #4288: Support Group By for PostgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4288: Support Group By for PostgreSQL for visitor
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4288: Support Group By for PostgreSQL for visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4288#issuecomment-585650739
## Pull Request Test Coverage Report for [Build 9503](https://coveralls.io/builds/28707380)
* **0** of **9** **(0.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.03%**) to **62.971%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28707380/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L271) | 0 | 9 | 0.0%
<!-- | **Total:** | **0** | **9** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/28707380) |
| :-- | --: |
| Change from base [Build 9502](https://coveralls.io/builds/28706975): | -0.03% |
| Covered Lines: | 11006 |
| Relevant Lines: | 17478 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services