You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Keith Wannamaker <Ke...@Wannamaker.org> on 2002/05/20 22:26:05 UTC
[PATCH] CompilerClasspath jspc attribute
Here is the final proposed patch for a compilerclasspath
attribute to jspc:
http://apache.org/~keith/cc.txt
This attribute specifies a classpath in which to find a
custom compiler adaptor.
The patch includes code changes, doc changes, and two
additional jspc tests. The jspc tests require two files
in jakarta-ant/src/etc/testcases/taskdefs/optional/jsp:
http://apache.org/~keith/DummyAdapter.java.txt (without the .txt)
http://apache.org/~keith/DummyAdapter.class
Note unless you have an older Tomcat 4.x jasper which
actually passes the tests, use the Tomcat 3.x jasper
and comment the mangler test in JspcTest.java.
I'll be glad to tweak these changes, I'm eager to get
them committed.
An additional javadoc fix is here
http://apache.org/~keith/bft.txt
Thanks,
Keith
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH] CompilerClasspath jspc attribute
Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
| > Here is the final proposed patch for a compilerclasspath
| > attribute to jspc:
| > http://apache.org/~keith/cc.txt
| >
| > This attribute specifies a classpath in which to find a
| > custom compiler adaptor.
| >
| > The patch includes code changes, doc changes, and two
| > additional jspc tests.
| > http://apache.org/~keith/DummyAdapter.java.txt (without the .txt)
|
| I like these, I like your tests and am motivated to put them into ant1.5,
| though I think that dummyadapter should compile down as part of the test
| build...there is no point having .class files in CVS if we have the source.
Great news, thanks for taking a look at them. I left the current
patches as-is and created a patch for the build:
http://apache.org/~keith/build.txt
This compiles DummyAdaptor to the right place and allows the source
to live in:
jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional
| > Note unless you have an older Tomcat 4.x jasper which
| > actually passes the tests, use the Tomcat 3.x jasper
| > and comment the mangler test in JspcTest.java.
|
| Aah, that must be half my problem; I am using a working version of jasper I
| have around :)
Yeah, I'm not sure what is going on with the head of Jasper right now. I
saw a flurry of 'improvement' commits lately to TC4 Jasper, so I think
something just got broken temporarily.
| Actually even then, it is broken as it doesnt do directories. the JasperC
| compiler needs to break the list of files up and hand single directories to
| jasper.
Hmm, I've never run into that because we always use jspc for flat directories.
Keith
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] CompilerClasspath jspc attribute
Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: "Keith Wannamaker" <Ke...@Wannamaker.org>
To: <an...@jakarta.apache.org>
Sent: Monday, May 20, 2002 1:26 PM
Subject: [PATCH] CompilerClasspath jspc attribute
> Here is the final proposed patch for a compilerclasspath
> attribute to jspc:
> http://apache.org/~keith/cc.txt
>
> This attribute specifies a classpath in which to find a
> custom compiler adaptor.
>
> The patch includes code changes, doc changes, and two
> additional jspc tests. The jspc tests require two files
> in jakarta-ant/src/etc/testcases/taskdefs/optional/jsp:
> http://apache.org/~keith/DummyAdapter.java.txt (without the .txt)
> http://apache.org/~keith/DummyAdapter.class
I like these, I like your tests and am motivated to put them into ant1.5,
though I think that dummyadapter should compile down as part of the test
build...there is no point having .class files in CVS if we have the source.
> Note unless you have an older Tomcat 4.x jasper which
> actually passes the tests, use the Tomcat 3.x jasper
> and comment the mangler test in JspcTest.java.
Aah, that must be half my problem; I am using a working version of jasper I
have around :)
Actually even then, it is broken as it doesnt do directories. the JasperC
compiler needs to break the list of files up and hand single directories to
jasper.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>