You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/08/31 20:01:40 UTC
[PR] [MRESOLVER-1954] Upgrade maven-resolver-transport-apache to Apache HttpComponents 5.x [maven-resolver]
slachiewicz opened a new pull request, #2103:
URL: https://github.com/apache/maven-resolver/pull/2103
Draft PR for https://github.com/apache/maven-resolver/issues/1954
### Summary of Changes:
- Upgrade `maven-resolver-transport-apache` from Apache HttpClient 4.x / HttpCore 4.x to Apache HttpClient 5.x / HttpCore 5.x (`5.4.x` / `5.3.x`).
- Adapt `SharingHttpContext`, session connection pooling, TLS `SSLSession` context adaptation, and proxy routing.
- Implement thread-safe auth scheme caching using HC5's `StateHolder` (`BasicScheme.store()` / `restore()`).
- Guard `PutTaskEntity` against premature body transmission on expect-continue rejection (`terminateRequest`).
- Ensure `HttpTransporterUtils` handles both Boolean and String session configuration values.
- All 118 unit and integration tests passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Upgrade maven-resolver-transport-apache to Apache HttpComponents 5.x [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5492648728
I'd not touch Wagon, is legacy, everything is moving away from it (maybe site only is not?).
My point is that it would be better to have the two apache transports (4 and 5) coexist, as it would allow for example to keep 3.10 with apache4 but in Maven 4 (ie 4.1) move to apache5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Add maven-resolver-transport-apache5 module backed by Apache HttpComponents 5.x [maven-resolver]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #2103: [MRESOLVER-1954] Add maven-resolver-transport-apache5 module backed by Apache HttpComponents 5.x
URL: https://github.com/apache/maven-resolver/pull/2103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Add maven-resolver-transport-apache5 module backed by Apache HttpComponents 5.x [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5587663220
Why was this closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Upgrade maven-resolver-transport-apache to Apache HttpComponents 5.x [maven-resolver]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5492618458
I'll check how wagon beehive and I this it should be possible to move it also quickly.
So far this change is more for 2.1 than 2.0 but if it works I'm open to integrate it faster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Upgrade maven-resolver-transport-apache to Apache HttpComponents 5.x [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5492550926
Supercool, but few remarks:
* we need apache-httpclient 4.x still (ie. it shares same client with Wagon HTTP)
* could you just "move" this into _new_ module, named like `maven-resolver-transport-apache5`? That would allow them to coexist
* so integrating like (ie Maven) have a free choice which one to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Add maven-resolver-transport-apache5 module backed by Apache HttpComponents 5.x [maven-resolver]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5546021388
I would rather opt for reducing the number of HTTP transporters in resolver. This module is the fifth one:
1. Apache HTTP Client 4.5
2. JRE HTTP Client (Java 11+)
3. Jetty HTTP Client (Java 17+)
4. UrlConnection
5. Apache HTTP Client 5.x
Why is 2. not sufficient with 1. and 4. as fallbacks for Java 8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Add maven-resolver-transport-apache5 module backed by Apache HttpComponents 5.x [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5641264222
So, why was this closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Add maven-resolver-transport-apache5 module backed by Apache HttpComponents 5.x [maven-resolver]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5546321766
> I would rather opt for reducing the number of HTTP transporters in resolver. This module is the fifth one:
>
> 1. Apache HTTP Client 4.5
> Why is 2. not sufficient with 1. and 4. as fallbacks for Java 8?
goal is to move away from not supported http 4.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Add maven-resolver-transport-apache5 module backed by Apache HttpComponents 5.x [maven-resolver]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5561225831
For me option 1 (based on legacy Apache HTTP Client 4.5) is good enough as fallback for Java 8. Maven 4 will use JRE HTTP Client. I don't yet see a need to ship another HTTP impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-1954] Add maven-resolver-transport-apache5 module backed by Apache HttpComponents 5.x [maven-resolver]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2103:
URL: https://github.com/apache/maven-resolver/pull/2103#issuecomment-5495540960
@cstamas Updated as suggested!
### Summary of updates:
- **Dedicated Module:** Created `maven-resolver-transport-apache5` (backed by Apache HttpClient `5.4.2` / HttpCore `5.3.3`) with `@Named("apache5")` and package `org.eclipse.aether.transport.apache5`.
- **Preserved Existing Transporter:** `maven-resolver-transport-apache` (HttpClient 4.5.x) is left completely untouched for full compatibility with Wagon HTTP and existing Maven 3.x setups.
- **Reviewable Git History:** Structured the branch with a 2-commit history:
1. Module creation derived from `maven-resolver-transport-apache`.
2. The exact HC5 migration + behavior parity hardening.
- **Verification:** Full reactor build (32 modules) and all 118 unit/integration tests in `apache5` (as well as `apache`) pass cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org