[jira] [Commented] (DRILL-1324) Detect schema changes when complex vector changes internally

["Jinfeng Ni (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192777#comment-14192777 ] 

Jinfeng Ni commented on DRILL-1324:
-----------------------------------

Overall, the change makes sense to me.   Some comments:

1. If SchemaChangeCallBack is applicable to Map/RepeatedList/RepeatedMap only, is it a good idea to define "callback" in AbstractContainerVector. ( Seems the method of addOrGet() in map/RepeatedMap are identical?)

2. RepeatedList would pass "callback" to its children, while Map/RepeatedMap would not. Is this the wanted behavior?  That is, we do not want to detect a new filed added in a map nested in another map / repeated map. Does it make sense to implement two choices : one only detects the top level schema change, the other one detects schema change recursively ?  The caller who creates the vector should tell the vector which behavior it wants.  

3. The patch changes ProjectRecordBatch, and does not touch the other operator. Does it mean only Project care schema change within a map, or other operators may also care?

4. In ProjectRecordBatch, "callback" is passed down for the "evaluation" case.  Do we need consider complex writer case?



> Detect schema changes when complex vector changes internally 
> -------------------------------------------------------------
>
>                 Key: DRILL-1324
>                 URL: https://issues.apache.org/jira/browse/DRILL-1324
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Mehant Baid
>            Assignee: Jinfeng Ni
>             Fix For: 0.6.0
>
>         Attachments: DRILL-1324.patch
>
>
> Currently we indicate a schema change only if the top level vector in the container changes. We need to detect changes when we add a vector to the top level Map, Repeated Map, Repeated List in the container. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)