You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/12/19 00:17:35 UTC
svn commit: r1646574 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java
Author: tilman
Date: Thu Dec 18 23:17:34 2014
New Revision: 1646574
URL: http://svn.apache.org/r1646574
Log:
PDFBOX-2576: avoid using implementation types, use the interface instead
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java?rev=1646574&r1=1646573&r2=1646574&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java Thu Dec 18 23:17:34 2014
@@ -388,14 +388,14 @@ public class COSDocument extends COSBase
{
// Some fields may contain twice references to a single field.
// This will prevent such double entries.
- HashMap<COSObjectKey, COSDictionary> signatures = new HashMap<COSObjectKey, COSDictionary>();
+ Map<COSObjectKey, COSDictionary> signatures = new HashMap<COSObjectKey, COSDictionary>();
for ( Object object : fields )
{
COSObject dict = (COSObject)object;
if (COSName.SIG.equals(dict.getItem(COSName.FT)))
{
COSBase dictionaryObject = dict.getDictionaryObject(COSName.V);
- if (dictionaryObject == null || (dictionaryObject != null && !onlyEmptyFields))
+ if (dictionaryObject == null || !onlyEmptyFields)
{
signatures.put(new COSObjectKey(dict), (COSDictionary)dict.getObject());
}
@@ -505,6 +505,7 @@ public class COSDocument extends COSBase
*
* @throws IOException If there is an error close resources.
*/
+ @Override
public void close() throws IOException
{
if (!closed)