You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "RuiChen (Code Review)" <ge...@cloudera.org> on 2020/03/23 07:25:43 UTC
[kudu-CR] KUDU-3088 Fix rebuild issue when thirdparty changed
RuiChen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15526
Change subject: KUDU-3088 Fix rebuild issue when thirdparty changed
......................................................................
KUDU-3088 Fix rebuild issue when thirdparty changed
Update the check logic in build-if-necessary.sh in order to
trigger rebuild when thirdparty directory changed in git repository.
Change-Id: Id67ac3c92ab1ad37e982cd5f9b21c97382eef1b6
---
M thirdparty/build-if-necessary.sh
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/15526/1
--
To view, visit http://gerrit.cloudera.org:8080/15526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id67ac3c92ab1ad37e982cd5f9b21c97382eef1b6
Gerrit-Change-Number: 15526
Gerrit-PatchSet: 1
Gerrit-Owner: RuiChen <ch...@gmail.com>
[kudu-CR] KUDU-3088 Fix rebuild issue when thirdparty changed
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15526 )
Change subject: KUDU-3088 Fix rebuild issue when thirdparty changed
......................................................................
Patch Set 1:
Sorry I'm not quite understanding why this change is needed.
Could you illustrate with an example (i.e. a sequence of commands from your shell showing how a change was made yet the thirdparty tree was not rebuilt), preferably summarized in the commit description?
--
To view, visit http://gerrit.cloudera.org:8080/15526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id67ac3c92ab1ad37e982cd5f9b21c97382eef1b6
Gerrit-Change-Number: 15526
Gerrit-PatchSet: 1
Gerrit-Owner: RuiChen <ch...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Mar 2020 20:53:30 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3088 Fix rebuild issue when thirdparty changed
Posted by "RuiChen (Code Review)" <ge...@cloudera.org>.
RuiChen has abandoned this change. ( http://gerrit.cloudera.org:8080/15526 )
Change subject: KUDU-3088 Fix rebuild issue when thirdparty changed
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/15526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id67ac3c92ab1ad37e982cd5f9b21c97382eef1b6
Gerrit-Change-Number: 15526
Gerrit-PatchSet: 1
Gerrit-Owner: RuiChen <ch...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: RuiChen <ch...@gmail.com>
[kudu-CR] KUDU-3088 Fix rebuild issue when thirdparty changed
Posted by "RuiChen (Code Review)" <ge...@cloudera.org>.
RuiChen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15526 )
Change subject: KUDU-3088 Fix rebuild issue when thirdparty changed
......................................................................
Patch Set 1:
Wired, I can't reproduce the issue in latest master branch, let's close the patch and jira issue first, I will keep eye open it.
--
To view, visit http://gerrit.cloudera.org:8080/15526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id67ac3c92ab1ad37e982cd5f9b21c97382eef1b6
Gerrit-Change-Number: 15526
Gerrit-PatchSet: 1
Gerrit-Owner: RuiChen <ch...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: RuiChen <ch...@gmail.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 07:24:22 +0000
Gerrit-HasComments: No