[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4055: [Doris On ES] Add docvalue limitation for doc_values scan and enable doc_values scan default

[GitBox <gi...@apache.org>]

wuyunfeng commented on a change in pull request #4055:
URL: https://github.com/apache/incubator-doris/pull/4055#discussion_r451982340



##########
File path: be/src/exec/es/es_scroll_query.cpp
##########
@@ -76,14 +76,20 @@ std::string ESScrollQueryBuilder::build(const std::map<std::string, std::string>
     // note: add `query` for this value....
     es_query_dsl.AddMember("query", query_node, allocator);
     bool pure_docvalue = true;
-    // check docvalue sacan optimization
-    if (docvalue_context.size() == 0 || docvalue_context.size() < fields.size()) {
-        pure_docvalue = false;
+
+    // Doris FE already has checked docvalue-scan optimization
+    if (properties.find(ESScanReader::KEY_DOC_VALUE_MODE) != properties.end()) {
+        pure_docvalue = atoi(properties.at(ESScanReader::KEY_DOC_VALUE_MODE).c_str());

Review comment:
       个人感觉这种值的设定是由FE完全控制的，倒还好




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org