You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by overmeulen <gi...@git.apache.org> on 2018/06/27 12:00:23 UTC
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
GitHub user overmeulen opened a pull request:
https://github.com/apache/qpid-broker-j/pull/9
[QPID-8208] Fix Sybase support for the link-store
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/overmeulen/qpid-broker-j bugfix/QPID-8208
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-broker-j/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit 664c066f00c1c4bb4d381629441d999453735fca
Author: overmeulen <ov...@...>
Date: 2018-06-27T11:57:19Z
[QPID-8208] Fix Sybase support for the link-store
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by alex-rufous <gi...@git.apache.org>.
Github user alex-rufous commented on a diff in the pull request:
https://github.com/apache/qpid-broker-j/pull/9#discussion_r200406444
--- Diff: broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java ---
@@ -191,6 +194,7 @@ public void testUpgradeVirtualHostWithJDBCStoreAndDefaultPool()
context.put("qpid.jdbcstore.bigIntType", "mybigint");
context.put("qpid.jdbcstore.varBinaryType", "myvarbinary");
context.put("qpid.jdbcstore.blobType", "myblob");
+ context.put("qpid.jdbcstore.timestampType", "mytimestamp");
--- End diff --
Please undo the change as context variable "qpid.jdbcstore.timestampType" did not exist in previous model versions
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by alex-rufous <gi...@git.apache.org>.
Github user alex-rufous commented on a diff in the pull request:
https://github.com/apache/qpid-broker-j/pull/9#discussion_r200405733
--- Diff: broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java ---
@@ -106,6 +106,7 @@ public void testUpgradeVirtualHostWithJDBCStoreAndBoneCPPool()
hostAttributes.put("jdbcBigIntType", "mybigint");
hostAttributes.put("jdbcBlobType", "myblob");
hostAttributes.put("jdbcVarbinaryType", "myvarbinary");
+ hostAttributes.put("jdbcTimestampType", "mytimestamp");
--- End diff --
Please undo the change as attribute "jdbcTimestampType" never existed in previous models
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by overmeulen <gi...@git.apache.org>.
Github user overmeulen commented on a diff in the pull request:
https://github.com/apache/qpid-broker-j/pull/9#discussion_r200465916
--- Diff: broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/JDBCDetails.java ---
@@ -379,7 +403,8 @@ public boolean isOverridden()
return contextMap.containsKey(CONTEXT_JDBCSTORE_USEBYTESFORBLOB)
|| contextMap.containsKey(CONTEXT_JDBCSTORE_BIGINTTYPE)
|| contextMap.containsKey(CONTEXT_JDBCSTORE_VARBINARYTYPE)
- || contextMap.containsKey(CONTEXT_JDBCSTORE_BLOBTYPE);
+ || contextMap.containsKey(CONTEXT_JDBCSTORE_BLOBTYPE)
--- End diff --
The method modified here is isOverridden() not isUseBytesMethodForBlob()
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by alex-rufous <gi...@git.apache.org>.
Github user alex-rufous commented on a diff in the pull request:
https://github.com/apache/qpid-broker-j/pull/9#discussion_r200406371
--- Diff: broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java ---
@@ -131,6 +132,7 @@ public void testUpgradeVirtualHostWithJDBCStoreAndBoneCPPool()
context.put("qpid.jdbcstore.bigIntType", "mybigint");
context.put("qpid.jdbcstore.varBinaryType", "myvarbinary");
context.put("qpid.jdbcstore.blobType", "myblob");
+ context.put("qpid.jdbcstore.timestampType", "mytimestamp");
--- End diff --
Please undo the change as context variable "qpid.jdbcstore.timestampType" did not exist in previous model versions
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j issue #9: [QPID-8208] Fix Sybase support for the link-store
Posted by overmeulen <gi...@git.apache.org>.
Github user overmeulen commented on the issue:
https://github.com/apache/qpid-broker-j/pull/9
Strange, the issue I created is nowhere to be found... I'll create a new one and link this PR to it
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j issue #9: [QPID-8208] Fix Sybase support for the link-store
Posted by k-wall <gi...@git.apache.org>.
Github user k-wall commented on the issue:
https://github.com/apache/qpid-broker-j/pull/9
Olivier, thanks for the PR, but QPID-8208 appears to be a typo (it relates to LDAP auth provider error handling rather than this problem). Can you correct and we'll review?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by overmeulen <gi...@git.apache.org>.
Github user overmeulen closed the pull request at:
https://github.com/apache/qpid-broker-j/pull/9
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by alex-rufous <gi...@git.apache.org>.
Github user alex-rufous commented on a diff in the pull request:
https://github.com/apache/qpid-broker-j/pull/9#discussion_r200576595
--- Diff: broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/JDBCDetails.java ---
@@ -379,7 +403,8 @@ public boolean isOverridden()
return contextMap.containsKey(CONTEXT_JDBCSTORE_USEBYTESFORBLOB)
|| contextMap.containsKey(CONTEXT_JDBCSTORE_BIGINTTYPE)
|| contextMap.containsKey(CONTEXT_JDBCSTORE_VARBINARYTYPE)
- || contextMap.containsKey(CONTEXT_JDBCSTORE_BLOBTYPE);
+ || contextMap.containsKey(CONTEXT_JDBCSTORE_BLOBTYPE)
--- End diff --
My apologies. Please ignore my comment. I overlooked method name
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by alex-rufous <gi...@git.apache.org>.
Github user alex-rufous commented on a diff in the pull request:
https://github.com/apache/qpid-broker-j/pull/9#discussion_r200407725
--- Diff: broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/JDBCDetails.java ---
@@ -379,7 +403,8 @@ public boolean isOverridden()
return contextMap.containsKey(CONTEXT_JDBCSTORE_USEBYTESFORBLOB)
|| contextMap.containsKey(CONTEXT_JDBCSTORE_BIGINTTYPE)
|| contextMap.containsKey(CONTEXT_JDBCSTORE_VARBINARYTYPE)
- || contextMap.containsKey(CONTEXT_JDBCSTORE_BLOBTYPE);
+ || contextMap.containsKey(CONTEXT_JDBCSTORE_BLOBTYPE)
--- End diff --
Please undo the change as context variable for timestamp type should not be used to indicate to use bytes methods for blob.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by alex-rufous <gi...@git.apache.org>.
Github user alex-rufous commented on a diff in the pull request:
https://github.com/apache/qpid-broker-j/pull/9#discussion_r200404852
--- Diff: broker-core/src/main/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecoverer.java ---
@@ -735,6 +735,7 @@ public MutableEntry transform(MutableEntry entry)
addAttributeTransformer("jdbcBytesForBlob", addContextVar("qpid.jdbcstore.useBytesForBlob")).
addAttributeTransformer("jdbcBlobType", addContextVar("qpid.jdbcstore.blobType")).
addAttributeTransformer("jdbcVarbinaryType", addContextVar("qpid.jdbcstore.varBinaryType")).
+ addAttributeTransformer("jdbcTimestampType", addContextVar("qpid.jdbcstore.timestampType")).
--- End diff --
The VirtualHostEntryUpgrader is used to upgrade record for model of version "1.3" into "2.0". There was no attribute "jdbcTimestampType" in model 1.3. The line needs to be deleted
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-broker-j pull request #9: [QPID-8208] Fix Sybase support for the link-s...
Posted by alex-rufous <gi...@git.apache.org>.
Github user alex-rufous commented on a diff in the pull request:
https://github.com/apache/qpid-broker-j/pull/9#discussion_r200406409
--- Diff: broker-core/src/test/java/org/apache/qpid/server/store/BrokerStoreUpgraderAndRecovererTest.java ---
@@ -165,6 +167,7 @@ public void testUpgradeVirtualHostWithJDBCStoreAndDefaultPool()
hostAttributes.put("jdbcBigIntType", "mybigint");
hostAttributes.put("jdbcBlobType", "myblob");
hostAttributes.put("jdbcVarbinaryType", "myvarbinary");
+ hostAttributes.put("jdbcTimestampType", "mytimestamp");
--- End diff --
Please undo the change as context variable "qpid.jdbcstore.timestampType" did not exist in previous model versions
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org