[jira] [Commented] (FLINK-10022) Add metrics for input/output buffers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579618#comment-16579618 ] 

ASF GitHub Bot commented on FLINK-10022:
----------------------------------------

NicoK opened a new pull request #6551: [FLINK-10022][network][metrics] add metrics for input/output buffers
URL: https://github.com/apache/flink/pull/6551
 
 
   ## What is the purpose of the change
   
   For debugging network issues, it would be nice to not only have the number of received/sent records and bytes but also the number of buffers, e.g. to identify low buffer fill rates which cause some overhead (there's a trade-off between sending full buffers and sending with low latency). This PR adds such metrics.
   
   ## Brief change log
   
   - add
   
   ## Verifying this change
   
   This change added checks to existing tests such as:
   - `TaskIOMetricGroupTest`
   - `SubtaskCurrentAttemptDetailsHandlerTest`
   - `SubtaskExecutionAttemptDetailsHandlerTest`
   - `JobVertexDetailsInfoTest`
   - `JobVertexTaskManagersInfoTest`
   - `JobDetailsInfoTest`
   - `SubtaskExecutionAttemptDetailsInfoTest`
   - I also verified the metrics manually in Flink's web UI
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no** (well, it adds metrics)
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **yes**
     - If yes, how is the feature documented? **docs, JavaDoc**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add metrics for input/output buffers
> ------------------------------------
>
>                 Key: FLINK-10022
>                 URL: https://issues.apache.org/jira/browse/FLINK-10022
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics, Network
>    Affects Versions: 1.5.2, 1.6.0, 1.7.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, we provide metrics for the input and output queue lengths, records and bytes. For diagnosing network issues, it would also be nice to know the number of buffers because we would then know their fill rate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)