You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/08/08 20:39:54 UTC
[native-toolchain-CR] Use realpath to determine relative path
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20332
Change subject: Use realpath to determine relative path
......................................................................
Use realpath to determine relative path
Removes use of 'python', which can fail on newer machines that don't
add the symlink, in favor of 'realpath'.
Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
---
M functions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/32/20332/1
--
To view, visit http://gerrit.cloudera.org:8080/20332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] Use realpath to determine relative path
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20332 )
Change subject: Use realpath to determine relative path
......................................................................
Use realpath to determine relative path
Removes use of 'python', which can fail on newer machines that don't
add the symlink, in favor of 'realpath'.
$ python -c "import os.path; print(os.path.relpath('/usr/lib', '/usr/bin'))"
../lib
$ realpath --relative-to=/usr/bin /usr/lib
../lib
Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
---
M functions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/32/20332/2
--
To view, visit http://gerrit.cloudera.org:8080/20332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] Use realpath to determine relative path
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20332 )
Change subject: Use realpath to determine relative path
......................................................................
Patch Set 2:
Kudu builds still require a python symlink.
--
To view, visit http://gerrit.cloudera.org:8080/20332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Aug 2023 20:51:24 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Use realpath to determine relative path
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20332 )
Change subject: Use realpath to determine relative path
......................................................................
Patch Set 2: Code-Review+2
This makes sense to me
--
To view, visit http://gerrit.cloudera.org:8080/20332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Aug 2023 21:28:52 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Use realpath to determine relative path
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20332 )
Change subject: Use realpath to determine relative path
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Aug 2023 18:32:29 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Use realpath to determine relative path
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20332 )
Change subject: Use realpath to determine relative path
......................................................................
Use realpath to determine relative path
Removes use of 'python', which can fail on newer machines that don't
add the symlink, in favor of 'realpath'.
$ python -c "import os.path; print(os.path.relpath('/usr/lib', '/usr/bin'))"
../lib
$ realpath --relative-to=/usr/bin /usr/lib
../lib
Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
Reviewed-on: http://gerrit.cloudera.org:8080/20332
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M functions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I569ecc0ace59ed3c388ae4f31cd80a695d5af0b6
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>