You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/25 23:33:22 UTC

Review Request 57067: ATLAS-1598: fix for NPE in Hive hook while processing create-table

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57067/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1598
    https://issues.apache.org/jira/browse/ATLAS-1598


Repository: atlas


Description
-------

added a check for null before deferencing the value returned by handleEventOutputs()


Diffs
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 2b256d0 

Diff: https://reviews.apache.org/r/57067/diff/


Testing
-------

verified that unit tests pass successfully


Thanks,

Madhan Neethiraj


Re: Review Request 57067: ATLAS-1598: fix for NPE in Hive hook while processing create-table

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57067/#review166823
-----------------------------------------------------------


Ship it!




Ship It!

- Apoorv Naik


On Feb. 25, 2017, 11:33 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57067/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2017, 11:33 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1598
>     https://issues.apache.org/jira/browse/ATLAS-1598
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> added a check for null before deferencing the value returned by handleEventOutputs()
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 2b256d0 
> 
> Diff: https://reviews.apache.org/r/57067/diff/
> 
> 
> Testing
> -------
> 
> verified that unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 57067: ATLAS-1598: fix for NPE in Hive hook while processing create-table

Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57067/#review166821
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Feb. 25, 2017, 3:33 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57067/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2017, 3:33 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1598
>     https://issues.apache.org/jira/browse/ATLAS-1598
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> added a check for null before deferencing the value returned by handleEventOutputs()
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 2b256d0 
> 
> Diff: https://reviews.apache.org/r/57067/diff/
> 
> 
> Testing
> -------
> 
> verified that unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 57067: ATLAS-1598: fix for NPE in Hive hook while processing create-table

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57067/
-----------------------------------------------------------

(Updated Feb. 26, 2017, 8:36 a.m.)


Review request for atlas.


Changes
-------

including fixes for NPE in AtlasEntityStoreV1 while attempting to delete a non-existing entity


Bugs: ATLAS-1598
    https://issues.apache.org/jira/browse/ATLAS-1598


Repository: atlas


Description
-------

added a check for null before deferencing the value returned by handleEventOutputs()


Diffs (updated)
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 2b256d0 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c0355d9 

Diff: https://reviews.apache.org/r/57067/diff/


Testing
-------

verified that unit tests pass successfully


Thanks,

Madhan Neethiraj