[PR] Review and tidy solr/modules/scripting code [solr]

["epugh (via GitHub)" <gi...@apache.org>]

epugh opened a new pull request, #4839:
URL: https://github.com/apache/solr/pull/4839

   # Description
   
   Split out from #4743 into smaller, per-module PRs to make review easier. This PR contains only the tidy-up changes to `solr/modules/scripting`.
   
   # Solution
   
   Leverage IntelliJ warnings (redundant null-check removal, unnecessary `throws` removal, `.get(0)` → `.getFirst()`, `giberish` → `gibberish` typo fix kept in sync between the Java test and its `solrconfig.xml` fixture, javadoc/comment fixes). No behavior changes.
   
   # Tests
   
   existing
   
   Relates to #4743


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

Re: [PR] Review and tidy solr/modules/scripting code [solr]

["epugh (via GitHub)" <gi...@apache.org>]

epugh merged PR #4839:
URL: https://github.com/apache/solr/pull/4839


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org