You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mikhail Khludnev (Created) (JIRA)" <ji...@apache.org> on 2011/11/30 21:21:39 UTC
[jira] [Created] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
DIHCacheSupport ignores left side of where="xid=x.id" attribute
---------------------------------------------------------------
Key: SOLR-2933
URL: https://issues.apache.org/jira/browse/SOLR-2933
Project: Solr
Issue Type: Bug
Components: contrib - DataImportHandler
Affects Versions: 4.0
Reporter: Mikhail Khludnev
Priority: Minor
DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "James Dyer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-2933.
------------------------------
Resolution: Fixed
fixed. This bug was caused by SOLR-2382, trunk only, so no CHANGES.txt entry.
Trunk: r1245109 (bug fix & test improvement)
Branch_3x: r1245129 (test improvement only)
Thanks again, Mikhail.
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Assignee: James Dyer
> Priority: Minor
> Labels: noob, random
> Fix For: 3.6, 4.0
>
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "Mikhail Khludnev (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209648#comment-13209648 ]
Mikhail Khludnev commented on SOLR-2933:
----------------------------------------
Great, James! Thank you.
Let me refresh SOLR-3011 patch at next week, and I also would like to think about same thread-proof paging for plain JDBC EntityProcessor (w/o caches).
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Assignee: James Dyer
> Priority: Minor
> Labels: noob, random
> Fix For: 3.6, 4.0
>
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "Mikhail Khludnev (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216774#comment-13216774 ]
Mikhail Khludnev commented on SOLR-2933:
----------------------------------------
James,
Can't you have a look into my new SOLR-3011? I'm sure it rocks.
Thanks
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Assignee: James Dyer
> Priority: Minor
> Labels: noob, random
> Fix For: 3.6, 4.0
>
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "Mikhail Khludnev (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Khludnev updated SOLR-2933:
-----------------------------------
Issue Type: Sub-task (was: Bug)
Parent: SOLR-2382
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: noob, random
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "James Dyer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209462#comment-13209462 ]
James Dyer commented on SOLR-2933:
----------------------------------
I will commit this one shortly.
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Assignee: James Dyer
> Priority: Minor
> Labels: noob, random
> Fix For: 3.6, 4.0
>
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-2933) DIHCacheSupport ignores
left side of where="xid=x.id" attribute
Posted by "Mikhail Khludnev (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160304#comment-13160304 ]
Mikhail Khludnev edited comment on SOLR-2933 at 11/30/11 8:28 PM:
------------------------------------------------------------------
AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch pick up map class randomly in all DIH testcases.
It breaks [TestCachedSqlEntityProcessor.withKeyAndLookup|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup]. More explanations are [1|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13158689&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13158689] [2|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159418&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159418] [3|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159431&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159431]
Let me attach the fix tomorrow.
was (Author: mkhludnev):
AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch pick up map class randomly in all DIH testcases.
It breaks [TestCachedSqlEntityProcessor.withKeyAndLookup|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup]. More explanations are [1|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13158689&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13158689] [2|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159418&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159418] [3|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159431&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159431]
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: noob, random
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "James Dyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-2933:
-----------------------------
Fix Version/s: 4.0
3.6
for 3.6, we should backport the test improvement (only).
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Assignee: James Dyer
> Priority: Minor
> Labels: noob, random
> Fix For: 3.6, 4.0
>
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "James Dyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-2933:
-----------------------------
Attachment: SOLR-2933.patch
Mikhail,
I appreciate your being persistent with this one. I apologize for not understanding what you were getting at the first couple times you tried to explain, but I think I finally have a fix. See SOLR-2933.patch, attached.
The problem was caused by my not copying code properly from EntityProcessorBase to DIHCacheSupport. This broke support for the "where" parameter for cached entity processors. ("cachePk" & "cacheLookup" still work and can be used instead of "where" as a workaround).
Further, a shortcoming in TestCachedSqlEntityProcessor masked the problem. Although the primary key was not being picked up from the "where" property, the primary key was the first property being passed in. DIH then assumed (correctly in this case) the first column must be the primary key. So the test (#withKeyAndLookup) would pass even though by accident.
This patch:
1. Fixes the bug in DIHCacheSupport.
2. Modifies TestCachedSqlEntityProcessor to reverse the order of one of the incoming documents so that the primary key is not first.
3. Changes AbstractDataImportHandlerTestCas#createMap to use a LinkedHashMap so that the tested order will be preserved. The HashMap that was used prior would always put the primary key column before the others, even if the test specifies a different order, further masking the failure.
Mikhail, thank you for both pointing out my error and also the prior problems with the test.
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: noob, random
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "James Dyer (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer reassigned SOLR-2933:
--------------------------------
Assignee: James Dyer
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Assignee: James Dyer
> Priority: Minor
> Labels: noob, random
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "James Dyer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161861#comment-13161861 ]
James Dyer commented on SOLR-2933:
----------------------------------
{quote}
Why not add randomization for choosing map class
{quote}
createMap() is but a trifle to facilitate testing. Personally I think randomizing on various Map impl's here is confusing and it would not be intuitive why it was done. What is important is the order of the fields being sent to the MockDataSource. In this case, there are 2 fields: "id" and "desc". Having some rows put "id" first and the others put "desc" first is adequate to test all the possible variants. I also think it is a good idea to always use a Map that preserves order because when writing these tests, it is not intuitive (for me anyhow) that the Map you're creating is going to iterate in an order different than the one you specify. That is why I changed the Abstract class to always use a LinkedHashMap.
{quote}
"assuming that first column is a primary key" is a really user-"hostile" feature.
{quote}
I didn't investigate whether this is just a function of the test or if DIH "in real life" behaves this way. In any case, if this is truly a DIH feature, I wouldn't consider it hostile. The primary key comes first most of the time. In any case, I wanted to solve the bug that this JIRA issue address and no more. If we have questions about default behaviors and want to change how the features work that is probably left to a separate non-"bug" issue.
{quote}
test methods names withWhereClause() and withKeyAndLookup() at TestCachedSqlEntityProcessor should be swapped each other.
{quote}
I think you're right, but then again I didn't write these tests, so I'm not sure why they were named this way. Also, changing the names is not directly related to fixing the bug here. Personally, I would love to see the DIH tests get revamped someday so you could just glance through them and understand what they do and how.
In any case, now that I understand the bug and how to fix it, I would rather create a lean patch that someone can quickly evaluate and commit. If we add bloat or make it hard for a committer to understand it might just languish and remain unfixed for a long time.
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: noob, random
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-2933) DIHCacheSupport ignores
left side of where="xid=x.id" attribute
Posted by "Mikhail Khludnev (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160304#comment-13160304 ]
Mikhail Khludnev edited comment on SOLR-2933 at 11/30/11 8:31 PM:
------------------------------------------------------------------
AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch pick up map class randomly in all DIH testcases.
It breaks [TestCachedSqlEntityProcessor.withKeyAndLookup|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup]. More explanations are [1|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13158689&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13158689] [2|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159418&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159418] [3|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159431&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159431]
seed which reproduces the fail
{code}
ant test -Dtestcase=TestCachedSqlEntityProcessor -Dtestmethod=withKeyAndLookup -Dtests.seed=7735f677498f3558:-29c15941cc37921e:-32c8bd2280b92536 -Dargs="-Dfile.encoding=UTF-8"
{code}
Let me attach the fix tomorrow. It's not a big deal anyway.
was (Author: mkhludnev):
AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch pick up map class randomly in all DIH testcases.
It breaks [TestCachedSqlEntityProcessor.withKeyAndLookup|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup]. More explanations are [1|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13158689&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13158689] [2|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159418&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159418] [3|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159431&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159431]
Let me attach the fix tomorrow.
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: noob, random
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "Mikhail Khludnev (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161843#comment-13161843 ]
Mikhail Khludnev commented on SOLR-2933:
----------------------------------------
James,
I reviewed the path. It solves the issue. I have minor questions:
* you changed the AbstractDataImportHandlerTestCase.createMap() but for the particular issue. Why not add randomization for choosing map class as I did at my patch? It keeps all current tests green but gives us a chance to find similar cases, which will be somehow added further;
* but I still think that "assuming that first column is a primary key" is a really user-"hostile" feature. IMHO DIH config can be tuned by someone who is not necessarily a developer. For me it's quite natural to insert new field at the top of the field list. So, the current implementation can be unexpectedly impacted by reordering fields. Can't we prohibit SortedMapBackedCache.iterator(Object) if there is no cachePk="" specified, and remove primaryKeyName = rec.keySet().iterator().next()? i.e. what's the motivation for this implicit case?
* firstly I proposed to exclude one of the "feature" - leave only where="" or keep cachePk="" and cacheLookup="" only. But I've got that cachePk="" is used for keying cache's multimap. So, it can be useful without cacheLookup="". Now, I agree that both ways should be supported;
* test methods names withWhereClause() and withKeyAndLookup() at TestCachedSqlEntityProcessor should be swapped each other;
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: noob, random
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch, SOLR-2933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2933) DIHCacheSupport ignores left side of
where="xid=x.id" attribute
Posted by "Mikhail Khludnev (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Khludnev updated SOLR-2933:
-----------------------------------
Attachment: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch
AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch pick up map class randomly in all DIH testcases.
It breaks [TestCachedSqlEntityProcessor.withKeyAndLookup|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup]. More explanations are [1|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13158689&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13158689] [2|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159418&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159418] [3|https://issues.apache.org/jira/browse/SOLR-2382?focusedCommentId=13159431&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13159431]
> DIHCacheSupport ignores left side of where="xid=x.id" attribute
> ---------------------------------------------------------------
>
> Key: SOLR-2933
> URL: https://issues.apache.org/jira/browse/SOLR-2933
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: noob, random
> Attachments: AbstractDataImportHandlerTestCase.java-choose-map-randomly.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup] - it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup], which takes just first column as a primary key. That's why all tests are green.
> To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup] and make desc first and picked up as a primary key.
> To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].
> I'm attaching test breaking patch and seed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org