You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/01/03 00:46:52 UTC
Review Request 64902: [ATLAS-2331]: Provide option to start embedded
Solr server for Integration Tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2331
https://issues.apache.org/jira/browse/ATLAS-2331
Repository: atlas
Description
-------
JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
Diffs
-----
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
graphdb/janus/pom.xml 738cac9e
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 33c8296c
notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 80dc5142
pom.xml d472ae7c
repository/pom.xml 7096ddfc
repository/src/main/java/org/apache/atlas/solr/EmbeddedSolrServer.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 456a7784
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
Diff: https://reviews.apache.org/r/64902/diff/1/
Testing
-------
Validated that the local solr server is started before the run of ITs in webapp module.
To run ITs:
mvn clean install -DskipUTs
Thanks,
Sarath Subramanian
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/#review194680
-----------------------------------------------------------
Instead of having the indexing backend startup classes in test scope. I think it's better to create a submodule, where we can put such server startup classes and then the tests or production code can rely on the module for starting all embedded dependencies. This might help in reducing the amount of POM configuration we have put in after introduction of Janus graph
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java
Lines 134 (patched)
<https://reviews.apache.org/r/64902/#comment273616>
Something else => bad arguments
graphdb/janus/pom.xml
Line 169 (original)
<https://reviews.apache.org/r/64902/#comment273617>
Can you ensure that the test-jar is not present within distro war?
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
Lines 172 (patched)
<https://reviews.apache.org/r/64902/#comment273618>
Avoid printing stacktrace
pom.xml
Line 595 (original), 595 (patched)
<https://reviews.apache.org/r/64902/#comment273615>
Reason for downgrade ?
repository/pom.xml
Line 170 (original)
<https://reviews.apache.org/r/64902/#comment273619>
Please ensure that the test jar is not included in the distro war.
Check other such occurences too
- Apoorv Naik
On Jan. 3, 2018, 12:46 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64902/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2018, 12:46 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2331
> https://issues.apache.org/jira/browse/ATLAS-2331
>
>
> Repository: atlas
>
>
> Description
> -------
>
> JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
> graphdb/janus/pom.xml 738cac9e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 33c8296c
> notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 80dc5142
> pom.xml d472ae7c
> repository/pom.xml 7096ddfc
> repository/src/main/java/org/apache/atlas/solr/EmbeddedSolrServer.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 456a7784
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
> webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
>
>
> Diff: https://reviews.apache.org/r/64902/diff/1/
>
>
> Testing
> -------
>
> Validated that the local solr server is started before the run of ITs in webapp module.
>
> To run ITs:
> mvn clean install -DskipUTs
>
> We still see IT failures in webapp module, this will be addressed in ATLAS-2330
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/#review194681
-----------------------------------------------------------
pom.xml
Line 595 (original), 595 (patched)
<https://reviews.apache.org/r/64902/#comment273620>
starting with 2.19.1 of surefire, 'skipAfterFailureCount = n' was added which skips remaining tests after 'n' failures. If this property is not set, defaults to 0 - the build reports successfull even if there are test failures and logs in surefire reports. To avoid adding including property -Dsurefire.skipAfterFailureCount=1 everytime when building, downgraded the plugin version.
(Tried adding the property in parent pom's plugin property but it did not work for some reason)
http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#skipAfterFailureCount
- Sarath Subramanian
On Jan. 2, 2018, 4:46 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64902/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2018, 4:46 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2331
> https://issues.apache.org/jira/browse/ATLAS-2331
>
>
> Repository: atlas
>
>
> Description
> -------
>
> JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
> graphdb/janus/pom.xml 738cac9e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 33c8296c
> notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 80dc5142
> pom.xml d472ae7c
> repository/pom.xml 7096ddfc
> repository/src/main/java/org/apache/atlas/solr/EmbeddedSolrServer.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 456a7784
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
> webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
>
>
> Diff: https://reviews.apache.org/r/64902/diff/1/
>
>
> Testing
> -------
>
> Validated that the local solr server is started before the run of ITs in webapp module.
>
> To run ITs:
> mvn clean install -DskipUTs
>
> We still see IT failures in webapp module, this will be addressed in ATLAS-2330
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/
-----------------------------------------------------------
(Updated Jan. 4, 2018, 10:42 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Changes
-------
addressed review comments from Apoorv and David.
Bugs: ATLAS-2331
https://issues.apache.org/jira/browse/ATLAS-2331
Repository: atlas
Description
-------
JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
Diffs (updated)
-----
test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java 937c1d09
test-tools/src/main/resources/log4j.properties d62cf804
Diff: https://reviews.apache.org/r/64902/diff/5/
Changes: https://reviews.apache.org/r/64902/diff/4-5/
Testing
-------
Validated that the local solr server is started before the run of ITs in webapp module.
To run ITs:
mvn clean install -DskipUTs
We still see IT failures in webapp module, this will be addressed in ATLAS-2330
Thanks,
Sarath Subramanian
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Sarath Subramanian <sa...@apache.org>.
> On Jan. 3, 2018, 10:19 p.m., Apoorv Naik wrote:
> > common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java
> > Lines 142 (patched)
> > <https://reviews.apache.org/r/64902/diff/4/?file=1930171#file1930171line155>
> >
> > Avoid printing stack traces if possible.
ah, I thought I removed this.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/#review194735
-----------------------------------------------------------
On Jan. 3, 2018, 9 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64902/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2018, 9 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2331
> https://issues.apache.org/jira/browse/ATLAS-2331
>
>
> Repository: atlas
>
>
> Description
> -------
>
> JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
>
>
> Diffs
> -----
>
> common/pom.xml 29ce58ea
> common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
> common/src/test/resources/solr/collections.txt
> common/src/test/resources/solr/core-template/currency.xml
> common/src/test/resources/solr/core-template/lang/stopwords_en.txt
> common/src/test/resources/solr/core-template/protwords.txt
> common/src/test/resources/solr/core-template/schema.xml
> common/src/test/resources/solr/core-template/solrconfig.xml
> common/src/test/resources/solr/core-template/stopwords.txt
> common/src/test/resources/solr/core-template/synonyms.txt
> common/src/test/resources/solr/solr.xml
> graphdb/janus/pom.xml 738cac9e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
> pom.xml d472ae7c
> repository/pom.xml 7096ddfc
> test-tools/pom.xml PRE-CREATION
> test-tools/src/main/resources/log4j.properties PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
> webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
>
>
> Diff: https://reviews.apache.org/r/64902/diff/4/
>
>
> Testing
> -------
>
> Validated that the local solr server is started before the run of ITs in webapp module.
>
> To run ITs:
> mvn clean install -DskipUTs
>
> We still see IT failures in webapp module, this will be addressed in ATLAS-2330
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/#review194735
-----------------------------------------------------------
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java
Lines 55 (patched)
<https://reviews.apache.org/r/64902/#comment273697>
The file separator pattern is unix/mac only. Please adapt this code to be platform agnostic.
Review all such occurences
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java
Lines 100 (patched)
<https://reviews.apache.org/r/64902/#comment273698>
ternary check is unnecessary here. ret should be assigned the value of CollectionUtils.isNotEmpty(..) eval directly
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java
Lines 142 (patched)
<https://reviews.apache.org/r/64902/#comment273699>
Avoid printing stack traces if possible.
- Apoorv Naik
On Jan. 4, 2018, 5 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64902/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 5 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2331
> https://issues.apache.org/jira/browse/ATLAS-2331
>
>
> Repository: atlas
>
>
> Description
> -------
>
> JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
>
>
> Diffs
> -----
>
> common/pom.xml 29ce58ea
> common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
> common/src/test/resources/solr/collections.txt
> common/src/test/resources/solr/core-template/currency.xml
> common/src/test/resources/solr/core-template/lang/stopwords_en.txt
> common/src/test/resources/solr/core-template/protwords.txt
> common/src/test/resources/solr/core-template/schema.xml
> common/src/test/resources/solr/core-template/solrconfig.xml
> common/src/test/resources/solr/core-template/stopwords.txt
> common/src/test/resources/solr/core-template/synonyms.txt
> common/src/test/resources/solr/solr.xml
> graphdb/janus/pom.xml 738cac9e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
> pom.xml d472ae7c
> repository/pom.xml 7096ddfc
> test-tools/pom.xml PRE-CREATION
> test-tools/src/main/resources/log4j.properties PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
> webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
>
>
> Diff: https://reviews.apache.org/r/64902/diff/4/
>
>
> Testing
> -------
>
> Validated that the local solr server is started before the run of ITs in webapp module.
>
> To run ITs:
> mvn clean install -DskipUTs
>
> We still see IT failures in webapp module, this will be addressed in ATLAS-2330
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/#review194750
-----------------------------------------------------------
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java
Lines 147 (patched)
<https://reviews.apache.org/r/64902/#comment273726>
shouldn't this message be before the stop?
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java
Lines 152 (patched)
<https://reviews.apache.org/r/64902/#comment273727>
I suggest including the bad argument value in the message to ease correction. I suggest changing the error text to bad first argument.
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
Lines 205 (patched)
<https://reviews.apache.org/r/64902/#comment273725>
Why are we gobbling exceptions - are sure that there will be an error message produced for errors?
test-tools/src/main/resources/log4j.properties
Lines 17 (patched)
<https://reviews.apache.org/r/64902/#comment273724>
I suggest using meaningful names rather than A1 and A2.
- David Radley
On Jan. 4, 2018, 5 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64902/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 5 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2331
> https://issues.apache.org/jira/browse/ATLAS-2331
>
>
> Repository: atlas
>
>
> Description
> -------
>
> JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
>
>
> Diffs
> -----
>
> common/pom.xml 29ce58ea
> common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
> common/src/test/resources/solr/collections.txt
> common/src/test/resources/solr/core-template/currency.xml
> common/src/test/resources/solr/core-template/lang/stopwords_en.txt
> common/src/test/resources/solr/core-template/protwords.txt
> common/src/test/resources/solr/core-template/schema.xml
> common/src/test/resources/solr/core-template/solrconfig.xml
> common/src/test/resources/solr/core-template/stopwords.txt
> common/src/test/resources/solr/core-template/synonyms.txt
> common/src/test/resources/solr/solr.xml
> graphdb/janus/pom.xml 738cac9e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
> pom.xml d472ae7c
> repository/pom.xml 7096ddfc
> test-tools/pom.xml PRE-CREATION
> test-tools/src/main/resources/log4j.properties PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
> webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
>
>
> Diff: https://reviews.apache.org/r/64902/diff/4/
>
>
> Testing
> -------
>
> Validated that the local solr server is started before the run of ITs in webapp module.
>
> To run ITs:
> mvn clean install -DskipUTs
>
> We still see IT failures in webapp module, this will be addressed in ATLAS-2330
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Apoorv Naik <na...@gmail.com>.
> On Jan. 4, 2018, 6:19 a.m., Apoorv Naik wrote:
> > Ship It!
Overall looks like a good addition. Good for commit after the suggested fixes.
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/#review194736
-----------------------------------------------------------
On Jan. 4, 2018, 5 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64902/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 5 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2331
> https://issues.apache.org/jira/browse/ATLAS-2331
>
>
> Repository: atlas
>
>
> Description
> -------
>
> JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
>
>
> Diffs
> -----
>
> common/pom.xml 29ce58ea
> common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
> common/src/test/resources/solr/collections.txt
> common/src/test/resources/solr/core-template/currency.xml
> common/src/test/resources/solr/core-template/lang/stopwords_en.txt
> common/src/test/resources/solr/core-template/protwords.txt
> common/src/test/resources/solr/core-template/schema.xml
> common/src/test/resources/solr/core-template/solrconfig.xml
> common/src/test/resources/solr/core-template/stopwords.txt
> common/src/test/resources/solr/core-template/synonyms.txt
> common/src/test/resources/solr/solr.xml
> graphdb/janus/pom.xml 738cac9e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
> pom.xml d472ae7c
> repository/pom.xml 7096ddfc
> test-tools/pom.xml PRE-CREATION
> test-tools/src/main/resources/log4j.properties PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
> webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
>
>
> Diff: https://reviews.apache.org/r/64902/diff/4/
>
>
> Testing
> -------
>
> Validated that the local solr server is started before the run of ITs in webapp module.
>
> To run ITs:
> mvn clean install -DskipUTs
>
> We still see IT failures in webapp module, this will be addressed in ATLAS-2330
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/#review194736
-----------------------------------------------------------
Ship it!
Ship It!
- Apoorv Naik
On Jan. 4, 2018, 5 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64902/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 5 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2331
> https://issues.apache.org/jira/browse/ATLAS-2331
>
>
> Repository: atlas
>
>
> Description
> -------
>
> JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
>
>
> Diffs
> -----
>
> common/pom.xml 29ce58ea
> common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
> common/src/test/resources/solr/collections.txt
> common/src/test/resources/solr/core-template/currency.xml
> common/src/test/resources/solr/core-template/lang/stopwords_en.txt
> common/src/test/resources/solr/core-template/protwords.txt
> common/src/test/resources/solr/core-template/schema.xml
> common/src/test/resources/solr/core-template/solrconfig.xml
> common/src/test/resources/solr/core-template/stopwords.txt
> common/src/test/resources/solr/core-template/synonyms.txt
> common/src/test/resources/solr/solr.xml
> graphdb/janus/pom.xml 738cac9e
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
> pom.xml d472ae7c
> repository/pom.xml 7096ddfc
> test-tools/pom.xml PRE-CREATION
> test-tools/src/main/resources/log4j.properties PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
> webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
>
>
> Diff: https://reviews.apache.org/r/64902/diff/4/
>
>
> Testing
> -------
>
> Validated that the local solr server is started before the run of ITs in webapp module.
>
> To run ITs:
> mvn clean install -DskipUTs
>
> We still see IT failures in webapp module, this will be addressed in ATLAS-2330
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/
-----------------------------------------------------------
(Updated Jan. 3, 2018, 9 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Changes
-------
moved the server startup classes to a separate module.
Bugs: ATLAS-2331
https://issues.apache.org/jira/browse/ATLAS-2331
Repository: atlas
Description
-------
JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
Diffs (updated)
-----
common/pom.xml 29ce58ea
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
common/src/test/resources/solr/collections.txt
common/src/test/resources/solr/core-template/currency.xml
common/src/test/resources/solr/core-template/lang/stopwords_en.txt
common/src/test/resources/solr/core-template/protwords.txt
common/src/test/resources/solr/core-template/schema.xml
common/src/test/resources/solr/core-template/solrconfig.xml
common/src/test/resources/solr/core-template/stopwords.txt
common/src/test/resources/solr/core-template/synonyms.txt
common/src/test/resources/solr/solr.xml
graphdb/janus/pom.xml 738cac9e
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
pom.xml d472ae7c
repository/pom.xml 7096ddfc
test-tools/pom.xml PRE-CREATION
test-tools/src/main/resources/log4j.properties PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
Diff: https://reviews.apache.org/r/64902/diff/4/
Changes: https://reviews.apache.org/r/64902/diff/3-4/
Testing
-------
Validated that the local solr server is started before the run of ITs in webapp module.
To run ITs:
mvn clean install -DskipUTs
We still see IT failures in webapp module, this will be addressed in ATLAS-2330
Thanks,
Sarath Subramanian
Re: Review Request 64902: [ATLAS-2331]: Provide option to start
embedded Solr server for Integration Tests
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64902/
-----------------------------------------------------------
(Updated Jan. 3, 2018, 12:01 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2331
https://issues.apache.org/jira/browse/ATLAS-2331
Repository: atlas
Description
-------
JanusGraph 0.2.0 doesn't provide option to start its own indexing backend when started in embedded mode. This JIRA provides an option to start a local solr server before the IntegrationTest runs.
Diffs (updated)
-----
common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4
graphdb/janus/pom.xml 738cac9e
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java e507a8ad
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java d764da4a
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java 7c33f10b
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java fd062568
pom.xml d472ae7c
repository/pom.xml 7096ddfc
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 4256043f
webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java e65d6789
Diff: https://reviews.apache.org/r/64902/diff/3/
Changes: https://reviews.apache.org/r/64902/diff/2-3/
Testing
-------
Validated that the local solr server is started before the run of ITs in webapp module.
To run ITs:
mvn clean install -DskipUTs
We still see IT failures in webapp module, this will be addressed in ATLAS-2330
Thanks,
Sarath Subramanian