You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/09/07 00:16:38 UTC
[GitHub] [calcite] tjbanghart opened a new pull request, #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter
tjbanghart opened a new pull request, #2896:
URL: https://github.com/apache/calcite/pull/2896
Firebolt does not support filter clauses in aggregate functions. e.g. COUNT(*) FILTER (WHERE a = 2).
The [dialect implementation](https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/sql/dialect/FireboltSqlDialect.java) should override the `supportsAggregateFunctionFilter` method it currently inherits from the base [SqlDialect class](https://github.com/apache/calcite/blob/b9c2099ea92a575084b55a206efc5dd341c0df62/core/src/main/java/org/apache/calcite/sql/SqlDialect.java#L758)
Firebolt SQL reference: https://docs.firebolt.io/sql-reference/functions-reference/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] tjbanghart commented on pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter
Posted by GitBox <gi...@apache.org>.
tjbanghart commented on PR #2896:
URL: https://github.com/apache/calcite/pull/2896#issuecomment-1239596312
Thanks for taking a look. I added a simple unit test in `RelToSqlConverterTest`. I think that should be sufficient but please let me know if it needs more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] asfgit closed pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter
URL: https://github.com/apache/calcite/pull/2896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] JiajunBernoulli commented on pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter
Posted by GitBox <gi...@apache.org>.
JiajunBernoulli commented on PR #2896:
URL: https://github.com/apache/calcite/pull/2896#issuecomment-1238822070
@tjbanghart , would you please add some unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zabetak commented on pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter
Posted by GitBox <gi...@apache.org>.
zabetak commented on PR #2896:
URL: https://github.com/apache/calcite/pull/2896#issuecomment-1239232332
@tjbanghart The best place to add tests about the change is `RelToSqlConverterTest`. Please verify that generated queries actually run in `Firebolt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org