You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2017/01/31 10:14:50 UTC

[GitHub] flink issue #3202: [FLINK-5631] [yarn] Support downloading additional jars f...

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3202
  
    @haohui I think it would be nice to have this change without moving the function to a different class. Then the diffs would be easier to read (check what part of the functionality was actually changed).
    
    If this is mainly about testing and visibility, then you can increase the visibility of the method from `private` to `package-private`, add a `@VisibleForTesting` annotation and place the test in the same package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---