You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by brandonJY <gi...@git.apache.org> on 2018/01/18 09:09:50 UTC
[GitHub] spark pull request #20312: [Docs] change to dataset for java code in structu...
GitHub user brandonJY opened a pull request:
https://github.com/apache/spark/pull/20312
[Docs] change to dataset for java code in structured-streaming-kafka-integration document
## What changes were proposed in this pull request?
In latest structured-streaming-kafka-integration document, Java code example for Kafka integration is using `DataFrame<Row>`, shouldn't it be changed to `DataSet<Row>`?
## How was this patch tested?
manual test has been performed to test the updated example Java code in Spark 2.2.1 with Kafka 1.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brandonJY/spark patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20312
----
commit 10afff276d23cbe98f8e4187791fb1358eff15fb
Author: brandonJY <br...@...>
Date: 2018-01-18T08:57:56Z
[Docs] change to dataset for java code in structured-streaming-kafka-integration document
In latest structured-streaming-kafka-integration document, Java code example for Kafka integration is using `DataFrame<Row>`, shouldn't it be changed to `DataSet<Row>`?
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20312: [Docs] change to dataset for java code in structured-str...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20312
**[Test build #4059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4059/testReport)** for PR 20312 at commit [`10afff2`](https://github.com/apache/spark/commit/10afff276d23cbe98f8e4187791fb1358eff15fb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20312: [Docs] change to dataset for java code in structured-str...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20312
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20312: [Docs] change to dataset for java code in structured-str...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20312
Merged to master/2.3/2.2
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20312: [Docs] change to dataset for java code in structured-str...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20312
**[Test build #4059 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4059/testReport)** for PR 20312 at commit [`10afff2`](https://github.com/apache/spark/commit/10afff276d23cbe98f8e4187791fb1358eff15fb).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20312: [Docs] change to dataset for java code in structured-str...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20312
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20312: [Docs] change to dataset for java code in structured-str...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20312
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20312: [Docs] change to dataset for java code in structu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20312
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org